Make a variable for backend timeout

[denissimonovski]

Can we refactor this hardcoded value with a variable?

terraform-google-lb-internal/main.tf

Line 51 in 12eb770

timeout_sec = 10

[morgante]

Should we potentially just use the same timeout as the health_check?

[denissimonovski]

I think that would be way better than this. It would be a great start, at least.

[morgante]

Sounds good, I've put it into our backlog. If you want to open a pull request, we'd be happy to review and it will likely land sooner.

[denissimonovski]

That's great. I'll take a look into this next week.

[denissimonovski]

@morgante I found this in the GCP docs:

For internal TCP/UDP load balancers and network load balancers, you can set the value of the backend service timeout using gcloud or the API, but the value is ignored. Backend service timeout has no meaning for these pass-through load balancers.
Source: https://cloud.google.com/load-balancing/docs/backend-service#timeout-setting

So whatever we put in the line I opened my issue for, doesn't make any difference. Since this is already an optional variable is it better to remove that line altogether and keep it clean? I can do it if you approve.

[morgante]

@denissimonovski Yes, go ahead and remove it. Please also leave a comment linking to this issue so we remember not to add it back.

[denissimonovski]

@morgante can you take a look at the open PR below?

[denissimonovski]

@morgante how about now?

[denissimonovski]

@morgante now?