feat: adds table_expiration_days and partition_expiration_days #143
Conversation
|
/gcbrun |
geojaz
force-pushed
the
add_default_partition_expiration_ms
branch
from
6ef5a90
to
d1ec4c7
Compare
Adds table_expiration_days and partition_expiration_days. BREAKING CHANGE: deprecrates expiration_days for clarity.
geojaz
force-pushed
the
add_default_partition_expiration_ms
branch
from
d1ec4c7
to
27567ac
Compare
|
@bharathkkb How do i fix this commit message? I checked out the docs and it looks like i'm fairly close. any advice? |
|
/gcbrun |
Hi @geojaz - Thanks of the contribution. It appears you need to update the PR's title which is currently "Adds table_expiration_days and partition_expiration_days; deprecates expiration_days". The first line of your PR's description looks like it would probably work. |
|
@geojaz |
geojaz
changed the title
|
duh, thanks :) |
There was a problem hiding this comment.
@geojaz Thanks for the PR! Let's preserve expiration_days for now just to prevent a breaking change and instead open an issue to bundle this in with our next breaking change.
Adds partition_expiration_days_ms. I've split out the mutation of the expiration_days param; I'll add a tracker issue and another PR that can be incorporated when we're ready to batch with other breaking changes.
geojaz
force-pushed
the
add_default_partition_expiration_ms
branch
from
00c3fb7
to
2b77260
Compare
geojaz
changed the title
geojaz
force-pushed
the
add_default_partition_expiration_ms
branch
from
2b77260
to
8f1e978
Compare
geojaz
changed the title
…ition_expiration_ms
geojaz
force-pushed
the
add_default_partition_expiration_ms
branch
from
8f1e978
to
bc27238
Compare
|
@bharathkkb Sounds good... this has been updated to keep |
|
/gcbrun |
|
@bharathkkb any other feedback on this one or are we good to go? |
|
@geojaz sorry for the delay just merged! |
feat!: Adds
partition_expiration_daysCloses #142
Nothing too complicated here, just adding a field per request of customer.
I will submit a second PR to deprecate
expiration_daysin favor oftable_expiration_daysfor clarity that can be merged when we have a batch of breaking changes.