Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps)!: Update Terraform terraform-google-modules/cloud-dns/google to v5 #489

Merged
merged 1 commit into from Nov 1, 2023
Merged

fix(deps)!: Update Terraform terraform-google-modules/cloud-dns/google to v5 #489

merged 1 commit into from Nov 1, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 24, 2023 •
edited

Mend Renovate

This PR contains the following updates:

Package Type Update Change Pending
terraform-google-modules/cloud-dns/google (source) module major ~> 4.1 -> ~> 5.0 5.1.1

Release Notes

terraform-google-modules/terraform-google-cloud-dns (terraform-google-modules/cloud-dns/google)

v5.1.0

Compare Source

Features

v5.0.1

Compare Source

Bug Fixes

v5.0.0

Compare Source

⚠ BREAKING CHANGES

  • Increased minimum Google Provider version to 4.40 (#​47)

  • add cloud logging option for public DNS (#​47)

Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from imrannayer and a team as code owners August 24, 2023 16:01
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 24, 2023
@dpebot
Copy link
Collaborator

dpebot commented Aug 24, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from a6e246d to d9c6ef0 Compare August 26, 2023 17:40
@dpebot
Copy link
Collaborator

dpebot commented Aug 26, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 11, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 11, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 11, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 11, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 19, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 22, 2023

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Sep 27, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from bc616a4 to f2d8fb6 Compare October 2, 2023 13:20
@dpebot
Copy link
Collaborator

dpebot commented Oct 2, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from f2d8fb6 to 0195fc6 Compare October 2, 2023 16:50
@dpebot
Copy link
Collaborator

dpebot commented Oct 2, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from 0195fc6 to 91135f6 Compare October 2, 2023 17:28
@dpebot
Copy link
Collaborator

dpebot commented Oct 2, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from 91135f6 to 839799c Compare October 3, 2023 14:24
@dpebot
Copy link
Collaborator

dpebot commented Oct 3, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from 839799c to 94ffbf8 Compare October 4, 2023 21:17
@dpebot
Copy link
Collaborator

dpebot commented Oct 4, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from 94ffbf8 to d57e243 Compare October 16, 2023 21:01
@dpebot
Copy link
Collaborator

dpebot commented Oct 16, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from d57e243 to ec35c9e Compare October 16, 2023 23:02
@dpebot
Copy link
Collaborator

dpebot commented Oct 16, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from ec35c9e to 579bd44 Compare October 18, 2023 20:33
@dpebot
Copy link
Collaborator

dpebot commented Oct 18, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from 579bd44 to e541d11 Compare October 27, 2023 21:12
@dpebot
Copy link
Collaborator

dpebot commented Oct 27, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from e541d11 to befd5df Compare October 27, 2023 21:45
@dpebot
Copy link
Collaborator

dpebot commented Oct 27, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from befd5df to 370c2eb Compare October 27, 2023 22:31
@dpebot
Copy link
Collaborator

dpebot commented Oct 27, 2023

/gcbrun

@renovate renovate bot force-pushed the renovate/major-tf-modules branch from 370c2eb to ac85856 Compare October 27, 2023 22:32
@dpebot
Copy link
Collaborator

dpebot commented Oct 27, 2023

/gcbrun

@wjf3121
Copy link

wjf3121 commented Nov 1, 2023

Is there any plan to merge this PR? the ~> 4.1 cloud-dns module restricts google provider below 5, which blocks us from upgrading the provider.

https://github.com/terraform-google-modules/terraform-google-cloud-dns/blob/v4.2.1/versions.tf#L21-L29

@imrannayer
Copy link
Collaborator

imrannayer commented Nov 1, 2023 •
edited

@wjf3121 NW module version 7.5 already allows max provider version 5.X.
Cloud dns 5.1.1 also supports max Provider 5.X

@wjf3121
Copy link

wjf3121 commented Nov 1, 2023

@imrannayer Thanks for the prompt reply!

The Cloud DNS module version NW module uses in private-service-connect is still 4.X, which supports max provider 4.X, shouldn't this restrict the google provider version to 4.X if private-service-connect is used?

terraform-google-network/modules/private-service-connect/dns.tf

Line 23 in 6475583

version = "~> 4.1"

@imrannayer
Copy link
Collaborator

@imrannayer Thanks for the prompt reply!

The Cloud DNS module version NW module uses in private-service-connect is still 4.X, which supports max provider 4.X, shouldn't this restrict the google provider version to 4.X if private-service-connect is used?

terraform-google-network/modules/private-service-connect/dns.tf

Line 23 in 6475583

version = "~> 4.1"

got it. Yes that sub-module will be taken care by this PR.

@imrannayer
Copy link
Collaborator

@apeabody

@apeabody
Copy link
Contributor

apeabody commented Nov 1, 2023

@imrannayer Thanks for the prompt reply!
The Cloud DNS module version NW module uses in private-service-connect is still 4.X, which supports max provider 4.X, shouldn't this restrict the google provider version to 4.X if private-service-connect is used?

terraform-google-network/modules/private-service-connect/dns.tf

Line 23 in 6475583

version = "~> 4.1"

got it. Yes that sub-module will be taken care by this PR.

Correct - Unfortunately this will be a breaking change, hence why we already released the other.

@apeabody apeabody merged commit adb3e2a into master Nov 1, 2023
5 checks passed
@apeabody apeabody deleted the renovate/major-tf-modules branch November 1, 2023 17:01
@release-please release-please bot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dpebot @wjf3121 @imrannayer @apeabody