Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgresql availability type shouldn't prevent backup configuration #351

Closed
saez0pub opened this issue Oct 6, 2022 · 0 comments · Fixed by #352 or #356
Closed

Postgresql availability type shouldn't prevent backup configuration #351

saez0pub opened this issue Oct 6, 2022 · 0 comments · Fixed by #352 or #356
Labels
bug Something isn't working

Comments

@saez0pub
Copy link
Contributor

saez0pub commented Oct 6, 2022

TL;DR

If I have an availability type REGIONAL, I should be able to disable point in time recovery and backups.

Expected behavior

  • Backups disabled
  • Point int time recovery disabled

Observed behavior

  • Backups enabled
  • Point int time recovery enabled

Terraform Configuration

module "pg" {
  source               = "./modules/postgresql"
  name                 = "mydb"
  project_id           = "myproject"
  availability_type    = "REGIONAL"
  backup_configuration = {
    enabled                        = false
    start_time                     = "20:55"
    location                       = null
    point_in_time_recovery_enabled = false
    transaction_log_retention_days = null
    retained_backups               = 365
    retention_unit                 = "COUNT"
  }
}

Terraform Version

Terraform v1.3.0

Additional information

No response

@saez0pub saez0pub added the bug Something isn't working label Oct 6, 2022
saez0pub added a commit to saez0pub/terraform-google-sql-db that referenced this issue Oct 6, 2022
saez0pub added a commit to saez0pub/terraform-google-sql-db that referenced this issue Oct 6, 2022
bharathkkb added a commit that referenced this issue Nov 1, 2022
…ion (#352)

fixes #351

Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant