Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Postgresql availability type shouldn't prevent backup configuration #352

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

saez0pub
Copy link
Contributor

@saez0pub saez0pub commented Oct 6, 2022

The old behaviour is still preserved but we are now able to configure some backup options.

fixes #351

@google-cla
Copy link

google-cla bot commented Oct 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@philip-harvey
Copy link

Thanks for the code update, this is an important fix, hopefully it will get merged soon

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @saez0pub

@comment-bot-dev
Copy link

@saez0pub
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit e796b3c into terraform-google-modules:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgresql availability type shouldn't prevent backup configuration
5 participants