feat: increased timeout to 30m to support micro instances also. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of the whole version name for postgres module.
…tead of the whole version name for postgres module.
…tead of the whole version name for postgres module.
…e there are some sensitive fields in google_sql_database_instance resource.
…le, since there are some sensitive fields in google_sql_database_instance resource." This reverts commit 6c3aeef.
…ation-toolkit/infra/blueprint-test to v0.4.0 (terraform-google-modules#387)
…form-google-modules#394) Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
…dule identical to mysql module
…es#392) Co-authored-by: Awais Malik <awmalik@google.com>
… for creating users with random password if password is set as null or an empty string.
…ud SQL instance modules.
…ud SQL instance modules.
…ud SQL instance modules.
|
/gcbrun |
apeabody
approved these changes
Feb 21, 2023
mnahkies
pushed a commit
to mnahkies/terraform-google-sql-db
that referenced
this pull request
Mar 12, 2023
run doc generation to pick-up default value change from terraform-google-modules#425 I think that ideally this would be checked for by CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to #416
Buganizer issue : b/270095290
Instances with <1 core take a LONG time to create. db-f1-micro will take ~25 minutes. The default in the module should be set to 30 minutes since that is what Terraform defaults to outside of using this module. Hence setting the timeout as 30 minutes for CUD operations in all instance modules.