Support separate insights_config for postgresql read replicas

[jawnsy]

TL;DR

The MySQL module allows read replicas to have a separate insights_config, which overrides the default:

terraform-google-sql-db/modules/mysql/variables.tf

Lines 255 to 259 in 2fcad8c

	insights_config = optional(object({
	query_string_length = number
	record_application_tags = bool
	record_client_address = bool
	}))

However, the PostgreSQL module does not:

terraform-google-sql-db/modules/postgresql/variables.tf

Lines 235 to 264 in 2fcad8c

	// Read Replicas
	variable "read_replicas" {
	description = "List of read replicas to create. Encryption key is required for replica in different region. For replica in same region as master set encryption_key_name = null"
	type = list(object({
	name = string
	name_override = optional(string)
	tier = string
	availability_type = string
	zone = string
	disk_type = string
	disk_autoresize = bool
	disk_autoresize_limit = number
	disk_size = string
	user_labels = map(string)
	database_flags = list(object({
	name = string
	value = string
	}))
	ip_configuration = object({
	authorized_networks = list(map(string))
	ipv4_enabled = bool
	private_network = string
	require_ssl = bool
	allocated_ip_range = string
	enable_private_path_for_google_cloud_services = optional(bool)
	})
	encryption_key_name = string
	}))
	default = []
	}

It's unclear whether this is a limitation of the database type or just the module. The PostgreSQL module seems to inherit the configuration from the primary:

terraform-google-sql-db/modules/postgresql/read_replica.tf

Line 64 in 2fcad8c

for_each = var.insights_config != null ? [var.insights_config] : []

Whereas the MySQL module uses the replica-specific setting (this should probably inherit settings from the primary, and only override in replicas if set, via the Terraform merge function or similar):

terraform-google-sql-db/modules/mysql/read_replica.tf

Line 46 in 2fcad8c

for_each = lookup(each.value, "insights_config") != null ? [lookup(each.value, "insights_config")] : []

Terraform Resources

No response

Detailed design

No response

Additional information

No response