Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cmek cloudsql 283 #284

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fix/cmek cloudsql 283 #284

merged 2 commits into from
Mar 10, 2022

Conversation

imrannayer
Copy link
Collaborator

Fix #283

@comment-bot-dev
Copy link

@imrannayer
Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

@jmymy Can you take a look and confirm this fixes your issue?

@jmymy
Copy link
Contributor

jmymy commented Mar 10, 2022

@jmymy Can you take a look and confirm this fixes your issue?

Ya looks good on my end. No changes to existing replicas!

Thanks @imrannayer for the quick turnaround!

@morgante morgante merged commit b73b465 into terraform-google-modules:master Mar 10, 2022
@imrannayer imrannayer deleted the fix/cmek-cloudsql-283 branch March 10, 2022 23:41
@imrannayer imrannayer self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If using CMEK on Postgres and with Replicas, the instance is recreated every terraform run
4 participants