-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make connector enforcement configurable #439
feat: make connector enforcement configurable #439
Conversation
We need to change our commit message to follow format mentioned here: https://www.conventionalcommits.org/en/v1.0.0/ |
This will allow the user to require the connection method for the MySQL CloudSQL. Refs: terraform-google-modules#438
Add the variable connector_enforcement to the Myqsl engine CloudSQL settings. Customers need to be able to ensure that clients are connecting only with the connector library as part of a security posture Refs: terraform-google-modules#438
Ensure that the documentation matches the actual default variable setting of false Refs: terraform-google-modules#438
Refs: terraform-google-modules#438 Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement Refs: terraform-google-modules#438
This will allow the user to require the connection method for the MySQL CloudSQL, but setting a variable. Users require the abilit to enforce only the connector library as a means of connection Refs: terraform-google-modules#438
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement Refs: terraform-google-modules#438
Add the variable connector_enforcement to the Myqsl engine CloudSQL settings. Customers need to be able to ensure that clients are connecting only with the connector library as part of a security posture Refs: terraform-google-modules#438
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement Refs: terraform-google-modules#438
Can you please pull latest main in your local and merge this branch with latest local main? this should remove |
This will allow the user to require the connection method for the MySQL CloudSQL, but setting a variable. Users require the abilit to enforce only the connector library as a means of connection Refs: terraform-google-modules#438
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement Refs: terraform-google-modules#438
Merge branch 'master' of github.com:terraform-google-modules/terraform-google-sql-db into configure_connector_enforcement Refs: terraform-google-modules#438
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please take a look at the var suggestion.
/gcbrun |
Fixes #438
Allows Mysql module users the ability to modify the connector_enforcement setting