Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make connector enforcement configurable #439

Merged

Conversation

maguec
Copy link
Contributor

@maguec maguec commented Mar 10, 2023

Fixes #438

Allows Mysql module users the ability to modify the connector_enforcement setting

@maguec maguec requested a review from a team as a code owner March 10, 2023 23:04
@isaurabhuttam
Copy link
Collaborator

We need to change our commit message to follow format mentioned here: https://www.conventionalcommits.org/en/v1.0.0/

maguec and others added 14 commits March 14, 2023 07:04
This will allow the user to require the connection method for the MySQL
CloudSQL.

Refs: terraform-google-modules#438
Add the variable connector_enforcement to the Myqsl engine CloudSQL
settings.
Customers need to be able to ensure that clients are connecting only
with the connector library as part of a security posture

Refs: terraform-google-modules#438
Ensure that the documentation matches the actual default variable
setting of false

Refs: terraform-google-modules#438
Refs: terraform-google-modules#438

Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement

Refs: terraform-google-modules#438
This will allow the user to require the connection method for the MySQL
CloudSQL, but setting a variable.

Users require the abilit to enforce only the connector library as a
means of connection

Refs: terraform-google-modules#438
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement

Refs: terraform-google-modules#438
Add the variable connector_enforcement to the Myqsl engine CloudSQL
settings.
Customers need to be able to ensure that clients are connecting only
with the connector library as part of a security posture

Refs: terraform-google-modules#438
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement

Refs: terraform-google-modules#438
@isaurabhuttam
Copy link
Collaborator

Can you please pull latest main in your local and merge this branch with latest local main? this should remove This branch is out-of-date with the base branch message. Before pulling latest master, make sure you sync your forked repository.

This will allow the user to require the connection method for the MySQL
CloudSQL, but setting a variable.

Users require the abilit to enforce only the connector library as a
means of connection

Refs: terraform-google-modules#438
Merge branch 'configure_connector_enforcement' of github.com:maguec/terraform-google-sql-db into configure_connector_enforcement

Refs: terraform-google-modules#438
Merge branch 'master' of github.com:terraform-google-modules/terraform-google-sql-db into configure_connector_enforcement

Refs: terraform-google-modules#438
@maguec maguec changed the title make connector enforcement configurable feat: make connector enforcement configurable Mar 15, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please take a look at the var suggestion.

modules/mysql/main.tf Show resolved Hide resolved
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 2df794b into terraform-google-modules:master Mar 15, 2023
@maguec maguec deleted the configure_connector_enforcement branch March 15, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to configure connector enforcement for Mysql Databases
4 participants