Skip to content

Commit

Permalink
fix: updates for tflint and dev-tools 1.11 (#180)
Browse files Browse the repository at this point in the history
  • Loading branch information
apeabody committed Apr 13, 2023
1 parent defb7c6 commit a2fb9b8
Show file tree
Hide file tree
Showing 12 changed files with 14 additions and 23 deletions.
1 change: 1 addition & 0 deletions .kitchen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
---
driver:
name: terraform
verify_version: false

provisioner:
name: terraform
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Make will use bash instead of sh
SHELL := /usr/bin/env bash

DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 1.0
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 1.11
DOCKER_IMAGE_DEVELOPER_TOOLS := cft/developer-tools
REGISTRY_URL := gcr.io/cloud-foundation-cicd

Expand Down
2 changes: 1 addition & 1 deletion build/int.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ tags:
- 'integration'
substitutions:
_DOCKER_IMAGE_DEVELOPER_TOOLS: 'cft/developer-tools'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.0'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.11'
2 changes: 1 addition & 1 deletion build/lint.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ tags:
- 'lint'
substitutions:
_DOCKER_IMAGE_DEVELOPER_TOOLS: 'cft/developer-tools'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.0'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.11'
5 changes: 0 additions & 5 deletions examples/shared_vpc_internal/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ provider "google" {
region = var.region
}

data "google_compute_network" "vault" {
name = var.network_name
project = var.host_project_id
}

data "google_compute_subnetwork" "vault" {
name = var.subnet_name
project = var.host_project_id
Expand Down
8 changes: 0 additions & 8 deletions examples/shared_vpc_internal/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ variable "kms_keyring" {
default = "vault-keyring"
}

variable "service_project_name" {
default = "vault-svpc-service"
}

variable "network_name" {
default = "vault-svpc"
}

variable "subnet_name" {
default = "vault"
}
Expand Down
1 change: 0 additions & 1 deletion examples/vault-on-gce/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ keys:
| allow\_public\_egress | Whether to create a NAT for external egress. If false, you must also specify an http\_proxy to download required executables including Vault, Fluentd and Stackdriver | `bool` | `true` | no |
| kms\_crypto\_key | Name of the GCP KMS crypto key | `string` | `"vault-init"` | no |
| kms\_keyring | Name of the GCP KMS keyring | `string` | `"vault"` | no |
| kms\_location | Location for the KMS keyring | `string` | `"us-east4"` | no |
| load\_balancing\_scheme | e.g. [INTERNAL\|EXTERNAL]. Scheme of the load balancer | `string` | `"EXTERNAL"` | no |
| project\_id | Project ID in which to deploy | `string` | n/a | yes |
| region | Region in which to deploy | `string` | `"us-east4"` | no |
Expand Down
6 changes: 0 additions & 6 deletions examples/vault-on-gce/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ variable "region" {
description = "Region in which to deploy"
}

variable "kms_location" {
type = string
default = "us-east4"
description = "Location for the KMS keyring"
}

variable "kms_keyring" {
type = string
default = "vault"
Expand Down
1 change: 1 addition & 0 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,5 @@ module "cluster" {
tls_save_ca_to_disk = var.tls_save_ca_to_disk
tls_save_ca_to_disk_filename = var.tls_save_ca_to_disk_filename
tls_ou = var.tls_ou
service_account_project_iam_roles = var.service_account_project_iam_roles
}
2 changes: 2 additions & 0 deletions modules/cluster/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ variable "tls_ca_subject" {

variable "tls_cn" {
description = "The TLS Common Name for the TLS certificates"
type = string
default = "vault.example.net"
}

Expand Down Expand Up @@ -396,5 +397,6 @@ variable "tls_save_ca_to_disk_filename" {

variable "tls_ou" {
description = "The TLS Organizational Unit for the TLS certificate"
type = string
default = "IT Security Operations"
}
5 changes: 5 additions & 0 deletions modules/cluster/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ terraform {
source = "hashicorp/google-beta"
version = ">= 3.53, < 5.0"
}

local = {
source = "hashicorp/local"
version = ">= 1.2.0"
}
}

provider_meta "google" {
Expand Down
2 changes: 2 additions & 0 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ variable "tls_ca_subject" {

variable "tls_cn" {
description = "The TLS Common Name for the TLS certificates"
type = string
default = "vault.example.net"
}

Expand Down Expand Up @@ -337,6 +338,7 @@ variable "tls_save_ca_to_disk_filename" {

variable "tls_ou" {
description = "The TLS Organizational Unit for the TLS certificate"
type = string
default = "IT Security Operations"
}

Expand Down

0 comments on commit a2fb9b8

Please sign in to comment.