feat: add account infrastructure base for resource group creation #53
+114
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
ocofaigh
requested changes
Jun 21, 2024
| "resource_group_name": $PREFIX, | ||
| "audit_resource_group_name": "{{PREFIX}}-audit", | ||
| "observability_resource_group_name": "{{PREFIX}}-observability", | ||
| "security_resource_group_name": "{{PREFIX}}-security", |
There was a problem hiding this comment.
what your trying to do here is not supported. However since a prefix value is added to these groups, you can just add any text in here and prefix value will ensure they are unique for every test, so they dont clash
| "key": "audit_resource_group_name", | ||
| "type": "string", | ||
| "default_value": "__NULL__", | ||
| "required": true |
| { | ||
| "key": "observability_resource_group_name", | ||
| "type": "string", | ||
| "default_value": "__NULL__", |
| "required": true | ||
| }, | ||
| { | ||
| "key": "security_resource_group_name", |
vburckhardt
requested changes
Jun 21, 2024
| "default": false, | ||
| "description": "Whether to use an existing resource group.", | ||
| "default": "us-south", | ||
| "description": "The region to deploy the Deployable Architecture", |
There was a problem hiding this comment.
The region in which all resources are deployed.
| @@ -244,6 +249,18 @@ | |||
| } | |||
| ], | |||
| "outputs": [ | |||
| { | |||
| "key": "audit_resource_group_name", | |||
| "description": "The Name of the audit Resource Group." | |||
There was a problem hiding this comment.
This would need to follow our editorial guidelines -
something like: "The name of the resource group that is created by this solution. The actual name is prefixed with the value of the input 'prefix'. All resources created by this solution are deployed in this resource group. "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new layer for the account infrastructure base and creates the audit, observability, and security resource groups based on what is set then passes that to the subsequent layers
NOTE:
due to existing resource group currently only being for the observability resource group in the account infrastructure base the input for existing resource group is removed, though we should be able to add the functionality to provide existing resource groups there
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers