Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default prefix #93

Merged
merged 1 commit into from
May 15, 2024
Merged

remove default prefix #93

merged 1 commit into from
May 15, 2024

Conversation

daniel-butler-irl
Copy link
Member

@daniel-butler-irl daniel-butler-irl commented May 15, 2024 •
edited
Loading

Description

Remove default prefix to help enforce unique names required by some services.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@daniel-butler-irl
Copy link
Member Author

/run pipeline

@vburckhardt vburckhardt merged commit f0cd67f into main May 15, 2024
2 checks passed
@vburckhardt vburckhardt deleted the remove-default-prefix branch May 15, 2024 11:42
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ocofaigh ocofaigh mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vburckhardt vburckhardt vburckhardt approved these changes

@ocofaigh ocofaigh Awaiting requested review from ocofaigh ocofaigh is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniel-butler-irl @terraform-ibm-modules-ops @vburckhardt