fscloud profile and example #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-butler-irl
force-pushed
the
latest_fscloud
branch
from
6eac619
to
9f5a833
Compare
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
daniel-butler-irl
force-pushed
the
latest_fscloud
branch
from
6239bb4
to
69abdd7
Compare
Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
ocofaigh
requested changes
Mar 29, 2023
examples/fscloud/version.tf
Outdated
| # Pin to the lowest provider version of the range defined in the main module to ensure lowest version still works | ||
| ibm = { | ||
| source = "ibm-cloud/ibm" | ||
| version = ">= 1.51.0" |
There was a problem hiding this comment.
As per the comment, pin the lowest version in the example - aka 1.51.0
There was a problem hiding this comment.
this one not done - examples should pin to lowest version in the range
…form-ibm-cos into latest_fscloud
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
ocofaigh
reviewed
Mar 30, 2023
ocofaigh
reviewed
Mar 30, 2023
There was a problem hiding this comment.
@daniel-butler-irl thanks for updates - still a couple of comments pending
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
Signed-off-by: Daniel Butler <dannyeb@gmail.com>
ocofaigh
approved these changes
Mar 30, 2023
|
🎉 This PR is included in version 5.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding FS cloud profile and tests
Types of changes in this PR
No release required
Release required
x.x.X): Change that fixes an issue and is compatible with earlier versions)x.X.x): Change that adds functionality and is compatible with earlier versions)X.x.x): Change that is likely incompatible with previous versions)Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.
Checklist for reviewers
Merge actions for mergers
Merge by using "Squash and merge".
Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).