chore: add service credentials to secrets manager in complete example #238
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
@Khuzaima05 You wont be able to do this until all of the secret related modules have moved from internal to public |
ocofaigh
requested changes
Oct 16, 2023
There was a problem hiding this comment.
@Khuzaima05 You should be able to proceed with this since we added https://github.com/terraform-ibm-modules/terraform-ibm-secrets-manager-secret-group and https://github.com/terraform-ibm-modules/terraform-ibm-secrets-manager-secret now
They also exist in hashicorp so pull from there instead of github
|
@Khuzaima05 you should be unblocked now to complete this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue : https://github.ibm.com/GoldenEye/issues/issues/4947
Types of changes in this PR
Changes that affect the core Terraform module or submodules
Changes that don't affect the core Terraform module or submodules
Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.
x.x.X)x.X.x)X.x.x)Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes help the merger write the commit message for the PR that is published in the release notes for the module.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
Merge actions for mergers