Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: onboarding module to ibm registery #484

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

rajatagarwal-ibm
Copy link
Member

Description

onboarding

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

README.md Outdated Show resolved Hide resolved
examples/default/README.md Outdated Show resolved Hide resolved
examples/default/README.md Outdated Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
ibm_catalog.json Show resolved Hide resolved
SKIP UPGRADE TEST: Changing example name
@rajatagarwal-ibm
Copy link
Member Author

Need to add CRA config - will add that in a separate PR

@ocofaigh
Copy link
Member

@rajatagarwal-ibm CRA PR has been merged

SKIP UPGRADE TEST: Changing example name
@ocofaigh ocofaigh merged commit 9bcc7e2 into main Nov 22, 2023
2 checks passed
@ocofaigh ocofaigh deleted the onboard-module-into-ibm-registry branch November 22, 2023 13:05
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants