Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent use of force_delete in kms modules #579

Merged
merged 6 commits into from
May 24, 2024
Merged

fix: consistent use of force_delete in kms modules #579

merged 6 commits into from
May 24, 2024

Conversation

iamar7
Copy link
Contributor

@iamar7 iamar7 commented May 23, 2024

Description

https://github.ibm.com/GoldenEye/issues/issues/9228

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Contributor Author

iamar7 commented May 23, 2024

/run pipeline

@iamar7
Copy link
Contributor Author

iamar7 commented May 23, 2024

/run pipeline

@iamar7
Copy link
Contributor Author

iamar7 commented May 23, 2024

/run pipeline

@iamar7
Copy link
Contributor Author

iamar7 commented May 23, 2024

This is failing upgrade test since the force_delete initially was defaulted to true but in this PR it is being changed to false. Need to skip the upgrade test.

Screenshot 2024-05-23 at 10 01 33 PM

@iamar7 iamar7 changed the title fix: update force-delete fix: consistent use of force_delete in kms modules May 23, 2024
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@iamar7
Copy link
Contributor Author

iamar7 commented May 24, 2024

/run pipeline

@iamar7
Copy link
Contributor Author

iamar7 commented May 24, 2024

/run pipeline

@ocofaigh ocofaigh merged commit ae52fda into main May 24, 2024
2 checks passed
@ocofaigh ocofaigh deleted the 9228-key branch May 24, 2024 15:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants