Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vpc data lookup #798

Merged
merged 13 commits into from
Jun 6, 2024
Merged

fix: vpc data lookup #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1366ab6
fix: vpc data full output on first apply
May 8, 2024
f82a44f
fix: vpc data full output on first apply
May 8, 2024
2e3ec0f
Merge branch 'main' into test
jor2 May 13, 2024
a4b275c
fix: name was null
May 13, 2024
126a870
fix: update code
May 14, 2024
6c6ea98
fix: update code
May 14, 2024
a9a0e43
fix: address feedback comments
May 14, 2024
7ab4434
fix: address feedback comments
May 14, 2024
211c059
Merge branch 'main' of github.com:terraform-ibm-modules/terraform-ibm…
Jun 6, 2024
3bd1e56
fix: lookup for vpc data
Jun 6, 2024
1977854
fix: variable defaults
Jun 6, 2024
cf91990
fix: update name
Jun 6, 2024
72ecef8
fix: standardise resources
jor2 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ data "ibm_is_vpc" "vpc" {
}

locals {
vpc_id = var.create_vpc ? resource.ibm_is_vpc.vpc[0].id : var.existing_vpc_id
vpc_id = var.create_vpc ? resource.ibm_is_vpc.vpc[0].id : var.existing_vpc_id
vpc_name = var.create_vpc ? resource.ibm_is_vpc.vpc[0].name : data.ibm_is_vpc.vpc.name
vpc_crn = var.create_vpc ? resource.ibm_is_vpc.vpc[0].crn : data.ibm_is_vpc.vpc.crn
}

##############################################################################
Expand Down
4 changes: 2 additions & 2 deletions outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

output "vpc_name" {
description = "Name of VPC created"
value = data.ibm_is_vpc.vpc.resource_name
value = local.vpc_name
}

output "vpc_id" {
Expand All @@ -14,7 +14,7 @@ output "vpc_id" {

output "vpc_crn" {
description = "CRN of VPC created"
value = data.ibm_is_vpc.vpc.crn
value = local.vpc_crn
}

##############################################################################
Expand Down