Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init vsi terraform module #1

Merged
merged 14 commits into from
Jul 6, 2022
Merged

init vsi terraform module #1

merged 14 commits into from
Jul 6, 2022

Conversation

argeiger
Copy link
Contributor

@argeiger argeiger commented Jun 9, 2022

No description provided.

@argeiger @jvallexm
init vsi terraform module
4bca793 
Co-authored-by: Jennifer Valle <jvallexm@gmail.com>
akocbek and others added 8 commits June 23, 2022 15:00
@akocbek
chore: add end to end example (#2)
303133e
@ocofaigh
Update main.tf
18ed637
@ocofaigh
Create ci.yml
084c563
@ocofaigh
Create release.yml
e25ef59
@ocofaigh
Update main.tf
dfefe3d
@ocofaigh
Update main.tf
52eff96
@ocofaigh
Update main.tf
c5d1008
@akocbek @akocbekIBM
feat: Add pre-commit checks (#3)
120e594 
* feat: Add pre-commit checks

* feat: Add pre-commit checks

* feat: Add pre-commit checks

* feat: Add pre-commit checks

* feat: Add pre-commit checks

Co-authored-by: Andrej Kocbek <akocbek@ie.ibm.com>
@vburckhardt
Copy link
Member

@akocbek - pre-commit are passing, but there are errors in the test. See https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/runs/7076174260?check_suite_focus=true#step:6:159

@akocbek @akocbekIBM
fix: example do not create ssh key if already exists (#4)
e68e629 
* fix: example do not create ssh key if already exists

* fix: example do not create ssh key if already exists

* fix: example do not create ssh key if already exists

* fix: example do not create ssh key if already exists

* fix: example do not create ssh key if already exists

* fix: example do not create ssh key if already exists

Co-authored-by: Andrej Kocbek <akocbek@ie.ibm.com>
@vburckhardt
Copy link
Member

vburckhardt commented Jun 28, 2022 •
edited
Loading

@akocbek @argeiger - FYI, I have not looked in details yet

TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │Error: image not found
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ with module.slz_vsi.ibm_is_instance.vsi["slz-vsi-q4lujr-3"],
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ on ../../main.tf line 50, in resource "ibm_is_instance" "vsi":
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ 50: resource "ibm_is_instance" "vsi" {
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: ╵
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: ╷
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │Error: image not found
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ with module.slz_vsi.ibm_is_instance.vsi["slz-vsi-q4lujr-1"],
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ on ../../main.tf line 50, in resource "ibm_is_instance" "vsi":
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ 50: resource "ibm_is_instance" "vsi" {
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: ╵
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: ╷
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │Error: image not found
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ with module.slz_vsi.ibm_is_instance.vsi["slz-vsi-q4lujr-2"],
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ on ../../main.tf line 50, in resource "ibm_is_instance" "vsi":
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │ 50: resource "ibm_is_instance" "vsi" {
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: │
TestRunBasicExample 2022-06-28T13:35:19Z logger.go:66: ╵
TestRunBasicExample 2022-06-28T13:35:19Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│Error: image not found
│
│ with module.slz_vsi.ibm_is_instance.vsi["slz-vsi-q4lujr-3"],
│ on ../../main.tf line 50, in resource "ibm_is_instance" "vsi":
│ 50: resource "ibm_is_instance" "vsi" {
│
╵
╷
│Error: image not found
│
│ with module.slz_vsi.ibm_is_instance.vsi["slz-vsi-q4lujr-1"],
│ on ../../main.tf line 50, in resource "ibm_is_instance" "vsi":
│ 50: resource "ibm_is_instance" "vsi" {
│
╵
╷
│Error: image not found
│
│ with module.slz_vsi.ibm_is_instance.vsi["slz-vsi-q4lujr-2"],
│ on ../../main.tf line 50, in resource "ibm_is_instance" "vsi":
│ 50: resource "ibm_is_instance" "vsi" {
│
╵}

akocbek and others added 2 commits June 28, 2022 15:08
@akocbek @akocbekIBM
fix: Force region when running tests (#6)
0981270 
Co-authored-by: Andrej Kocbek <akocbek@ie.ibm.com>
@ocofaigh
docs: readme cleanup
81521a8
@ocofaigh
Copy link
Member

ocofaigh commented Jul 1, 2022

@argeiger @jvallexm I have added a required permissions section to the readme, but unsure what exact permissions are required. Could you please fill it in? For example, here is what we put for the VPC module -> https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc#required-iam-access-policies

@vburckhardt
fix: resolve idempotency issue by explicitly using the vpc default sg (…
a4fefd8 
…#7)
@vburckhardt
Set default sg (#8)
a16880f 
* fix: resolve idempotency issue by explicitly using the vpc default sg

* fix: delay vpcs data lookup until new vpc created
@vburckhardt
Copy link
Member

@argeiger @jvallexm - Hello - all checks are now passing. Could you do a final review, and if everything is fine, we can merge and get the initial release.

@argeiger
Copy link
Contributor Author

argeiger commented Jul 6, 2022

Since I am the creator of the PR, I am not able to approve but the PR LGTM

@ocofaigh ocofaigh merged commit 26bcdc3 into main Jul 6, 2022
@ocofaigh ocofaigh deleted the init-vsi-mod branch July 6, 2022 14:33
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

Assignees

@jvallexm jvallexm

@argeiger argeiger

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@argeiger @vburckhardt @ocofaigh @terraform-ibm-modules-ops @jvallexm @akocbek