Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fscloud vsi #467

Merged
merged 18 commits into from
Jun 9, 2023
Merged

Fscloud vsi #467

merged 18 commits into from
Jun 9, 2023

Conversation

rajatagarwal-ibm
Copy link
Member

Description

FSCloud implementation for VSI

Types of changes in this PR

Changes that affect the core Terraform module or submodules

  • Bug fix
  • New feature
  • Dependency update

Changes that don't affect the core Terraform module or submodules

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.

Your notes help the merger write the commit message for the PR that is published in the release notes for the module.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to review, but perhaps you are still working on this?

profiles/fscloud/variables.tf Outdated Show resolved Hide resolved
examples/fscloud/README.md Outdated Show resolved Hide resolved
examples/default/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@rajatagarwal-ibm
Copy link
Member Author

@ocofaigh yeah the work is still in progress... its much of a draft version... i was focusing on some other stuff today so will be back on this tomorrow.

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

tests/pr_test.go Show resolved Hide resolved
storage.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
profiles/fscloud/README.md Outdated Show resolved Hide resolved
@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

variables.tf Outdated Show resolved Hide resolved
@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 8f10810 into main Jun 9, 2023
2 checks passed
@ocofaigh ocofaigh deleted the fscloud-vsi branch June 9, 2023 16:52
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants