[WIP - Do not merge] feat: update bigip images to latest

[argeiger]

Description

Update the F5 BigIP images to the current ones

Types of changes in this PR

No release required

• Examples or tests (addition or updates of examples or tests)
• Documentation update
• CI-related update (pipeline, etc.)
• Other changes that don't affect Terraform code

Release required

• Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
• New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
• Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content

Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

---

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

• Merge by using "Squash and merge".

• Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.

  The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

[vburckhardt]

lgtm (trusting you have the right ids ;) ), just need a merge with master here before merging.

[argeiger]

lgtm (trusting you have the right ids ;) ), just need a merge with master here before merging.

merged main in

[ocofaigh]

@argeiger would you classify this as a breaking (major) version change? Have we removed support for some F5 images?

[argeiger]

@argeiger would you classify this as a breaking (major) version change? Have we removed support for some F5 images?

@ocofaigh the F5 team removed the images so they are not available within the VPC images. I don't think we need a major change associated with this.

[ocofaigh]

@argeiger The test is failing on:

│ Error: Invalid value for variable
│ 
│   on ../../patterns/vpc/config.tf line 18, in module "dynamic_values":
│   18:   f5_image_name                       = var.f5_image_name
│     ├────────────────
│     │ var.f5_image_name is "f5-bigip-17-0-0-1-0-0-4-all-1slot"
│ 
│ Invalid F5 image name. Must be null or one of
│ [`f5-bigip-16-1-2-2-0-0-28-ltm-1slot`,`f5-bigip-16-1-2-2-0-0-28-all-1slot`,
│ `f5-bigip-16-1-3-3-0-0-3-ltm-1slot`, `f5-bigip-16-1-3-3-0-0-3-all-1slot`,
│ `f5-bigip-17-0-0-2-0-0-2-ltm-1slot`, `f5-bigip-17-0-0-2-0-0-2-all-1slot`].
│ 
│ This was checked by the validation rule at
│ ../../patterns/dynamic_values/variables.tf:166,3-13.
╵}

[ocofaigh]

@argeiger Is this PR still needed?

[argeiger]

@argeiger Is this PR still needed?

@ocofaigh we do need to update the images since the current ones do not exist anymore. I need to take a deeper look and see if we can do something that won't require the exact images for the validation check. Maybe have a generic validation check for format but point them to some doc that contains the image names.