fix: deploy vsi only to the vsi-zone-* subnets for null value #661
Conversation
|
/run pipeline |
|
@Aashiq-J I expect if we had an upgrade test for the "Existing VPC" VSI extension DA this change would actually fail the upgrade test because it will attempt to destroy VSIs from subnets that did not start with |
|
/run pipeline |
|
@ocofaigh , It is trying to recreate the vsi in the vsi-subnets and delete the ones in the other subnets. |
| @@ -598,3 +598,116 @@ func TestRunVsiExtention(t *testing.T) { | |||
| logger.Log(t, "END: Destroy (existing resources)") | |||
| } | |||
| } | |||
|
|
|||
| func TestRunUpgradeVsiExtention(t *testing.T) { | |||
There was a problem hiding this comment.
Is alot of the code here duplicated from the TestRunVsiExtention test? Can we maybe remove duplication by adding the common code to a function and having each test call that function?
| @@ -1,6 +1,6 @@ | |||
| # Add a VSI to a landing zone VPC | |||
|
|
|||
| This architecture creates virtual server instances (VSI) in some or all of the subnets of one VPC of an existing landing zone deployable architecture. To create VSIs in multiple VPCs, deploy the extension once for each VPC. | |||
| This architecture creates virtual server instances (VSI) in some or all of the VSI subnets of one VPC of an existing landing zone deployable architecture. To create VSIs in multiple VPCs, deploy the extension once for each VPC. | |||
There was a problem hiding this comment.
Same change needs to be made in ibm_catalog.json here
|
@Aashiq-J I wasn't expecting any new creates to be seen in the upgrade test? I thought current code was creating VSI in every subnet, and then the new code would delete the VSIs in the non VSI subnets. Why is code trying to create new VSIs? |
|
@ocofaigh , |
|
/run pipeline |
|
Need to update to v4 of VSI module, but can't do that until Projects provider official state migration step |
Description
Issue: https://github.ibm.com/GoldenEye/issues/issues/6951
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers