Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added eu-fr2 support in atracker and cos #785

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

Soaib024
Copy link
Member

@Soaib024 Soaib024 commented May 8, 2024

Description

Added eu-fr2 in the supported regions for Atracker route creation and regional COS
#773

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added eu-fr2 in the supported regions for Atracker route creation and regional COS

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Soaib024
Copy link
Member Author

Soaib024 commented May 8, 2024

/run pipeline

1 similar comment
@Soaib024
Copy link
Member Author

Soaib024 commented May 8, 2024

/run pipeline

@ocofaigh
Copy link
Member

ocofaigh commented May 9, 2024

The test failed with a network issue:

 2024/05/08 11:53:28 Terraform init | Error: Failed to install provider
 2024/05/08 11:53:28 Terraform init | 
 2024/05/08 11:53:28 Terraform init | Error while installing hashicorp/external v2.3.3: read tcp
 2024/05/08 11:53:28 Terraform init | 172.30.141.138:40592->108.138.85.30:443: read: connection reset by peer

Going to retry..

@ocofaigh
Copy link
Member

ocofaigh commented May 9, 2024

/run pipeline

@Soaib024
Copy link
Member Author

Soaib024 commented May 9, 2024

│ Error: Request failed with status code: 400, ServerErrorResponse: {"incidentID":"74e0224c-5659-4ad5-8419-c22ed22172ad,74e0224c-5659-4ad5-8419-c22ed22172ad","code":"A0020","description":"Unable to validate the request with resource group manager.","type":"Authentication","recoveryCLI":"To list available resource groups, run 'ibmcloud resource groups'. Make sure that your cluster and the other IBM Cloud resources that you are trying to use are in the same resource group. Verify that you have permissions to work with the resource group. If you think that the resource group is set up correctly and you still cannot use it, contact IBM Cloud support."}
│ 
│   with module.landing_zone.module.landing_zone.ibm_container_vpc_cluster.cluster["rokqsu-vgfuje-workload-cluster"],
│   on ../../cluster.tf line 38, in resource "ibm_container_vpc_cluster" "cluster":
│   38: resource "ibm_container_vpc_cluster" "cluster" {
│ 
╵}
=== NAME  TestRunUpgradeROKSQuickStartPattern
    tests.go:682: 
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper@v1.30.2/testhelper/tests.go:682
        	            				/__w/terraform-ibm-landing-zone/terraform-ibm-landing-zone/tests/pr_test.go:186
        	Error:      	Expected nil, but got: retry.FatalError{Underlying:(*shell.ErrWithCmdOutput)(0xc000f9e180)}
        	Test:       	TestRunUpgradeROKSQuickStartPattern
        	Messages:   	Terraform Apply on Base branch has failed

Again test failed because of something that is not related to changes made in PR

@Soaib024
Copy link
Member Author

Soaib024 commented May 9, 2024

/run pipeline

@ocofaigh ocofaigh closed this May 9, 2024
@ocofaigh ocofaigh reopened this May 9, 2024
@ocofaigh
Copy link
Member

ocofaigh commented May 9, 2024

The tests failed to known issue with destroy - unrelated to changes in this PR so proceeding to merge

@ocofaigh ocofaigh merged commit b2777c4 into main May 9, 2024
1 of 2 checks passed
@ocofaigh ocofaigh deleted the add-eu-fr2 branch May 9, 2024 19:18
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 5.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants