Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide the option to not use obs services #45

Merged
merged 23 commits into from
May 23, 2024
Merged

provide the option to not use obs services #45

merged 23 commits into from
May 23, 2024

Conversation

Aayush-Abhyarthi
Copy link
Contributor

@Aayush-Abhyarthi Aayush-Abhyarthi commented Apr 19, 2024

The DA supports creating logdna, sysdig, and ATracker. This PR exposes boolean variables for all of these to allow consumers to opt out of a particular service Allows user to use only the required observability services and opt out of any of them.

Issue: #41

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This release provides the support of opting out of any of the observability services in the DA.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

solutions/instances/main.tf Outdated Show resolved Hide resolved
solutions/instances/main.tf Outdated Show resolved Hide resolved
@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@iamar7
Copy link
Contributor

iamar7 commented Apr 23, 2024

/run pipeline

iamar7
iamar7 previously approved these changes Apr 23, 2024
Copy link
Contributor

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vburckhardt vburckhardt self-requested a review April 24, 2024 12:48
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the option to not provision activity tracker is set to true, all related objects - eg: cos instance, buckets, key protect should not be created as well.

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

iamar7
iamar7 previously approved these changes May 10, 2024
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. I also found a gap that need to be plugged where the buckets are not being configured with monitoring, Raised a new issue: #68

# AT targets and routes
########################################################################################################################

variable "configure_cos_target_and_route_for_atracker_events" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of #56 there is a new variable being added called enable_at_event_routing_to_cos. I suggest we go with that and merge that PR, and then rebase this PR

Copy link
Member

@ocofaigh ocofaigh May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aayush-Abhyarthi enable_at_event_routing_to_cos_bucket was already added in #56 - how does that differ to the variable you are adding here?

@ocofaigh
Copy link
Member

@Aayush-Abhyarthi Now that #56 has been merged, can you proceed with this PR please?

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget all new variables need to go into the ibm_catalog.json so they get ordered

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to need to extra validation here..

  • log_analysis_provision can't be false if enable_at_event_routing_to_log_analysis is true

Also you probably need to update the outputs (such as log_analysis_crn etc..) to default to null if user does not provision log analysis (same with the monitoring outputs)

solutions/instances/main.tf Outdated Show resolved Hide resolved
@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 7d16e74 into main May 23, 2024
2 checks passed
@ocofaigh ocofaigh deleted the obsr-8629 branch May 23, 2024 07:23
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants