Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an optional audit resource group #77

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MatthewLemmond
Copy link
Member

@MatthewLemmond MatthewLemmond commented May 14, 2024

Description

Create (or use an existing) resource group for audit resources created by the DA, added variable to test creation/use of the new resource group for audit resources

resolves #50

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add an optional resource group for use with audit resources by providing a value for the var.audit_resource_group_name and also the option to use an existing audit resource group by setting var.use_existing_audit_resource_group to true

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Create (or use an existing) resource group for audit resources created by the DA, added variable to test creation/use of the new resource group for audit resources
@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member

maheshwarishikha commented Jun 3, 2024

Updates are added in #8717 , need to update the code accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to deploy services in different resource groups
4 participants