Skip to content

Commit

Permalink
ci: Test fail fix due to calling wrong TestOptions
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan-Williams2 authored and Jordan-Williams2 committed May 2, 2023
1 parent 96e4bb3 commit 31e7c2c
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 34 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ You need the following permissions to run this module.
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >=1.3 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >=1.43.0 |
| <a name="requirement_time"></a> [time](#requirement\_time) | 0.9.1 |

## Modules

Expand All @@ -92,7 +91,6 @@ No modules.
| [ibm_is_subnet_reserved_ip.ip](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_subnet_reserved_ip) | resource |
| [ibm_is_virtual_endpoint_gateway.vpe](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_virtual_endpoint_gateway) | resource |
| [ibm_is_virtual_endpoint_gateway_ip.endpoint_gateway_ip](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_virtual_endpoint_gateway_ip) | resource |
| [time_sleep.wait_30_seconds](https://registry.terraform.io/providers/hashicorp/time/0.9.1/docs/resources/sleep) | resource |

## Inputs

Expand Down
8 changes: 8 additions & 0 deletions examples/default/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ module "vpes" {
cloud_services = var.cloud_services
cloud_service_by_crn = var.cloud_service_by_crn
service_endpoints = var.service_endpoints
depends_on = [time_sleep.wait_30_seconds]
}

resource "time_sleep" "wait_30_seconds" {
depends_on = [data.ibm_is_security_group.default_sg]

destroy_duration = "30s"
}


##############################################################################
4 changes: 4 additions & 0 deletions examples/default/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ terraform {
source = "IBM-Cloud/ibm"
version = "1.51.0"
}
time = {
source = "hashicorp/time"
version = "0.9.1"
}
}
}

Expand Down
8 changes: 0 additions & 8 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,8 @@ resource "ibm_is_virtual_endpoint_gateway" "vpe" {
crn = each.value.service == null ? each.value.crn : local.service_to_endpoint_map[each.value.service]
resource_type = "provider_cloud_service"
}
depends_on = [time_sleep.wait_30_seconds]
}

resource "time_sleep" "wait_30_seconds" {
depends_on = [ibm_is_subnet_reserved_ip.ip]

destroy_duration = "30s"
}


##############################################################################

##############################################################################
Expand Down
20 changes: 1 addition & 19 deletions module-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,6 @@
"version_constraints": [
"\u003e=1.43.0"
]
},
"time": {
"source": "hashicorp/time",
"version_constraints": [
"0.9.1"
]
}
},
"managed_resources": {
Expand Down Expand Up @@ -186,19 +180,7 @@
},
"pos": {
"filename": "main.tf",
"line": 101
}
},
"time_sleep.wait_30_seconds": {
"mode": "managed",
"type": "time_sleep",
"name": "wait_30_seconds",
"provider": {
"name": "time"
},
"pos": {
"filename": "main.tf",
"line": 88
"line": 93
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion tests/go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/terraform-ibm-modules/terraform-ibm-vpe-module
module github.com/terraform-ibm-modules/terraform-ibm-icse-vpe-module

go 1.20

Expand Down
4 changes: 0 additions & 4 deletions versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ terraform {
source = "IBM-Cloud/ibm"
version = ">=1.43.0"
}
time = {
source = "hashicorp/time"
version = "0.9.1"
}
}
required_version = ">=1.3"
}
Expand Down

0 comments on commit 31e7c2c

Please sign in to comment.