Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: available service endpoints added/fixed #409

Merged

Conversation

toddgiguere
Copy link
Contributor

@toddgiguere toddgiguere commented Oct 6, 2023

Description

Contains fixes and additions to the available multitenant services that can be configured with a Virtual Private Endpoint gateway.

Made sure that all multitenant services are tested.

fixes #396
fixes #390

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added new endpoints that are now available to be requested in the cloud_services input variable:

  • context-based-restrictions
  • ntp

Fixed issue with following service, endpoint will now properly deploy in region:

  • container-registry

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

2 similar comments
@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@vburckhardt
Copy link
Member

Hi Todd, I see a few more hpcs endpoints to add. The current logic only allows creating the api one.

image

Also tagging missing
image

Cos Config endpoint is missing as well
image

@vburckhardt
Copy link
Member

support center
image

@toddgiguere
Copy link
Contributor Author

@vburckhardt the challenge I am seeing is that the terraform block only supports adding via CRN or "name", and right now the only one that has "name" was "ntp".

If we can query ibmcloud is endpoint-gateway-targets and see the service, that is typically where I've been getting either the CRN or the official "name". I can check if any of these show up.

I haven't found a way to add a VPE endpoint by simply knowning its https endpoint, unless I'm missing something?

@toddgiguere
Copy link
Contributor Author

@vburckhardt I think I found all of these, and their configuration CRNs, and also some extra that I've found:

  • for hs-crypto, I can set the name of the service to have a suffix? such as "hs-crypto-cert-mgr"?
  • we already had "tagging", it is called "global-search-tagging"
  • COS config is found, will add
  • support center is found, will add

I've also found the following which I can add:

  • containers-kubernetes
  • sos (pimconsole.sos.ibm.com is endpoint? I'm not sure what this is?)
  • messaging
  • vmware

Let me know if we do not want to add those.

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

@vburckhardt you might notice that the PR test does not include all services, many are commented out. That is because I wanted the Upgrade test to run (the new services aren't available in main version). Once we get this PR released I will follow up with a test PR which will uncomment those services out, and at that point we will be testing them all.

I've already confirmed they are all working by running the every-mt-vpe example locally.

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for this.

@vburckhardt vburckhardt merged commit 195db64 into terraform-ibm-modules:main Nov 3, 2023
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add missing vpe support vpe to container registry result in error
3 participants