-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: available service endpoints added/fixed #409
fix: available service endpoints added/fixed #409
Conversation
Added CBR and NTP endpoints
endpoints handle private/public correctly when configuring domains
/run pipeline |
/run pipeline |
2 similar comments
/run pipeline |
/run pipeline |
/run pipeline |
@vburckhardt the challenge I am seeing is that the terraform block only supports adding via CRN or "name", and right now the only one that has "name" was "ntp". If we can query I haven't found a way to add a VPE endpoint by simply knowning its https endpoint, unless I'm missing something? |
@vburckhardt I think I found all of these, and their configuration CRNs, and also some extra that I've found:
I've also found the following which I can add:
Let me know if we do not want to add those. |
/run pipeline |
/run pipeline |
@vburckhardt you might notice that the PR test does not include all services, many are commented out. That is because I wanted the Upgrade test to run (the new services aren't available in main version). Once we get this PR released I will follow up with a test PR which will uncomment those services out, and at that point we will be testing them all. I've already confirmed they are all working by running the |
/run pipeline |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for this.
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Contains fixes and additions to the available multitenant services that can be configured with a Virtual Private Endpoint gateway.
Made sure that all multitenant services are tested.
fixes #396
fixes #390
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Added new endpoints that are now available to be requested in the
cloud_services
input variable:Fixed issue with following service, endpoint will now properly deploy in region:
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
Merge actions for mergers