feat: add reserved ip submodule #415

jor2 · 2023-10-09T16:59:22Z

Description

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Provides a way to create a reserved ip independently from the VPE creation. Ensures that the consumer has got full control on the reserved ip's being attached. This is used in the scenario where a consumer wants to have the same ip for a given VPE type across VPC's.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

jor2 · 2023-10-10T01:13:19Z

/run pipeline

vburckhardt · 2023-10-12T09:51:51Z

/run pipeline

jor2 · 2023-10-16T09:35:57Z

/run pipeline

jor2 · 2023-10-16T20:30:05Z

/run pipeline

jor2 · 2023-10-18T10:28:20Z

/run pipeline

vburckhardt · 2023-10-20T10:52:24Z

/run pipeline

vburckhardt

Hi Jordan, a couple of comments inline. Also the top level readme should have one or 2 sentences around the reserved ip feature and why it exists.

modules/reserved-ips/main.tf

variables.tf

main.tf

examples/reserved-ips/README.md

jor2 · 2023-11-02T16:37:48Z

/run pipeline

jor2 · 2023-11-07T15:42:22Z

/run pipeline

jor2 · 2023-11-08T20:30:10Z

blocked by #435

shemau · 2023-11-09T15:06:25Z

I have raised #437 as a possible solution to #435. It would require small changes to this PR.

jor2 · 2023-11-15T15:55:31Z

/run pipeline

jor2 · 2023-11-22T09:45:25Z

/run pipeline

jor2 · 2023-11-22T11:30:08Z

/run pipeline

jor2 · 2023-11-22T12:23:54Z

/run pipeline

jor2 · 2023-11-22T13:43:30Z

/run pipeline

jor2 · 2023-11-23T13:45:10Z

/run pipeline

jor2 · 2023-11-23T19:55:53Z

/run pipeline

jor2 · 2023-11-27T19:16:29Z

/run pipeline

jor2 · 2023-11-28T03:00:19Z

/run pipeline

shemau

There is an upgrade test in other_test.go. These tests are run during the continuous test, however, in that context what is the upgrade?

modules/reserved-ips/README.md

jor2 · 2023-12-05T11:44:44Z

/run pipeline

jor2 · 2023-12-05T16:34:26Z

/run pipeline

jor2 · 2023-12-14T17:58:42Z

/run pipeline

ocofaigh · 2024-01-04T21:16:14Z

/run pipeline

jor2 · 2024-01-05T10:36:44Z

/run pipeline

examples/reserved-ips/README.md

modules/reserved-ips/README.md

vburckhardt · 2024-01-08T09:46:56Z

modules/reserved-ips/README.md

+  ]
+  subnet_zone_list = [
+    [
+      {


Is there a reason for having to pass redundant data for the existing subnets that are targeted?

id, name, and zone are used in the naming convention in main module so also needed here if names are to match.

vburckhardt · 2024-01-08T09:47:49Z

modules/reserved-ips/README.md

+}
+```
+
+The above will create 6 new reserved ip's as such and output them:


Will that example really create 6 ips or just 3 given that 3 subnets are passed.

3 for each service passed in cloud_services.

vburckhardt · 2024-01-08T09:48:43Z

modules/reserved-ips/variables.tf

+variable "subnet_zone_list" {
+  description = "List of subnets in the VPC where gateways and reserved IPs will be provisioned. This value is intended to use the `subnet_zone_list` output from the Landing Zone VPC Subnet Module (https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc) or from templates using that module for subnet creation."
+  type = list(
+    object({


Do we really need to ask for all of those informations?

I could remove cidr, need others for naming convention.

vburckhardt · 2024-01-08T09:50:29Z

modules/reserved-ips/variables.tf

+  default     = "us-south"
+}
+
+variable "cloud_services" {


It's only used for the naming of the reserved ips, so I would make this field more generic to take a list of strings. Also the description is not accurate.

vpe_name maybe needed in naming convention to match main module.

jor2 · 2024-01-24T13:44:28Z

/run pipeline

jor2 · 2024-01-28T23:15:01Z

/run pipeline

jor2 · 2024-02-07T22:46:16Z

/run pipeline

jor2 · 2024-02-11T23:42:21Z

/run pipeline

jor2 · 2024-02-19T17:31:30Z

/run pipeline

jor2 · 2024-02-26T13:10:42Z

/run pipeline

jor2 self-assigned this Oct 9, 2023

jor2 marked this pull request as ready for review October 9, 2023 16:59

jor2 requested review from toddgiguere and vburckhardt October 9, 2023 17:49

vburckhardt requested changes Oct 20, 2023

View reviewed changes

modules/reserved-ips/main.tf Show resolved Hide resolved

variables.tf Outdated Show resolved Hide resolved

main.tf Outdated Show resolved Hide resolved

examples/reserved-ips/README.md Show resolved Hide resolved

shemau requested changes Nov 30, 2023

View reviewed changes

modules/reserved-ips/README.md Outdated Show resolved Hide resolved

modules/reserved-ips/README.md Outdated Show resolved Hide resolved

modules/reserved-ips/README.md Outdated Show resolved Hide resolved

jor2 requested review from vburckhardt and shemau December 15, 2023 14:59

ocofaigh previously approved these changes Jan 5, 2024

View reviewed changes

vburckhardt requested changes Jan 8, 2024

View reviewed changes

jor2 dismissed ocofaigh’s stale review via 8768804 January 9, 2024 00:01

jor2 requested a review from vburckhardt January 10, 2024 14:51

feat: add reserved ip submodule

cffb03d

jor2 force-pushed the pg-module branch from 48d544e to cffb03d Compare January 19, 2024 01:33

Jordan-Williams2 added 3 commits January 21, 2024 22:14

fix: pre-commit

2593d50

Merge branch 'main' into pg-module

449e533

fix: disable dns-svc for time being

2589915

Merge branch 'main' into pg-module

cdbe489

Merge branch 'main' into pg-module

282171d

Merge branch 'main' into pg-module

4aebeeb

jor2 added 3 commits February 19, 2024 13:54

Merge branch 'main' into pg-module

edc3cd4

Merge branch 'main' into pg-module

3886d9c

Merge branch 'main' into pg-module

7734015

Merge branch 'main' into pg-module

617c4fc

jor2 added 6 commits March 7, 2024 01:40

Merge branch 'main' into pg-module

ea42801

Merge branch 'main' into pg-module

f07a413

Merge branch 'main' into pg-module

cd22ecd

Merge branch 'main' into pg-module

3fd7ce1

Merge branch 'main' into pg-module

5c8ed3d

Merge branch 'main' into pg-module

82fb996

feat: add reserved ip submodule #415

Are you sure you want to change the base?

feat: add reserved ip submodule #415

Conversation

jor2 commented Oct 9, 2023 • edited

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

jor2 commented Oct 10, 2023

vburckhardt commented Oct 12, 2023

jor2 commented Oct 16, 2023

jor2 commented Oct 16, 2023

jor2 commented Oct 18, 2023

vburckhardt commented Oct 20, 2023

vburckhardt left a comment

Choose a reason for hiding this comment

jor2 commented Nov 2, 2023

jor2 commented Nov 7, 2023

jor2 commented Nov 8, 2023

shemau commented Nov 9, 2023

jor2 commented Nov 15, 2023

jor2 commented Nov 22, 2023

jor2 commented Nov 22, 2023

jor2 commented Nov 22, 2023

jor2 commented Nov 22, 2023

jor2 commented Nov 23, 2023

jor2 commented Nov 23, 2023

jor2 commented Nov 27, 2023

jor2 commented Nov 28, 2023

shemau left a comment

Choose a reason for hiding this comment

jor2 commented Dec 5, 2023

jor2 commented Dec 5, 2023

jor2 commented Dec 14, 2023

ocofaigh commented Jan 4, 2024

jor2 commented Jan 5, 2024

vburckhardt Jan 8, 2024

Choose a reason for hiding this comment

jor2 Jan 10, 2024 • edited

Choose a reason for hiding this comment

vburckhardt Jan 8, 2024

Choose a reason for hiding this comment

jor2 Jan 8, 2024

Choose a reason for hiding this comment

vburckhardt Jan 8, 2024

Choose a reason for hiding this comment

jor2 Jan 10, 2024

Choose a reason for hiding this comment

vburckhardt Jan 8, 2024

Choose a reason for hiding this comment

jor2 Jan 10, 2024

Choose a reason for hiding this comment

jor2 commented Jan 24, 2024

jor2 commented Jan 28, 2024

jor2 commented Feb 7, 2024

jor2 commented Feb 11, 2024

jor2 commented Feb 19, 2024

jor2 commented Feb 26, 2024

jor2 commented Oct 9, 2023 •

edited

jor2 Jan 10, 2024 •

edited