-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use regional data platform APIs #101
Conversation
/run pipeline |
/run pipeline |
/run pipeline |
@@ -16,9 +16,22 @@ iam_id="$(echo "$token_decoded" | jq -r .iam_id)" | |||
display_name="$(echo "$token_decoded" | jq -r .name)" | |||
bss_account_id="$(echo "$token_decoded" | jq -r .account.bss)" | |||
|
|||
# shellcheck disable=SC2154 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
@@ -16,9 +16,22 @@ iam_id="$(echo "$token_decoded" | jq -r .iam_id)" | |||
display_name="$(echo "$token_decoded" | jq -r .name)" | |||
bss_account_id="$(echo "$token_decoded" | jq -r .account.bss)" | |||
|
|||
# shellcheck disable=SC2154 | |||
if [ "$location" == "us-south" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use if [[ ]]
?
@@ -13,9 +13,22 @@ jwt_decode(){ | |||
token_decoded="$(jwt_decode "$token")" | |||
bss_account_id="$(echo "$token_decoded" | jq -r .account.bss)" | |||
|
|||
# shellcheck disable=SC2154 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers