Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve matcher path in single step #22

Merged
merged 2 commits into from Mar 29, 2022
Merged

Resolve matcher path in single step #22

merged 2 commits into from Mar 29, 2022

Conversation

bendrucker
Copy link
Member

Resolves the path to matchers.json in a single call. When the parent directory is separately constructed, the compiler has to consider the possibility that any file within that directory will be loaded:

ncc: Version 0.27.0
ncc: Compiling file index.js
  0kB  dist/.github/matchers.json
  0kB  dist/.github/workflows/semver.yml
  2kB  dist/.github/workflows/test.yml
305kB  dist/index.js
307kB  [1020ms] - ncc 0.27.0

By resolving the actual path to the desired file, the compiler can copy that specific file only:

ncc: Version 0.27.0
ncc: Compiling file index.js
  0kB  dist/matchers.json
305kB  dist/index.js
305kB  [1077ms] - ncc 0.27.0

This reduces potential spurious build diffs, as seen in #21

@bendrucker bendrucker merged commit 12a32fc into master Mar 29, 2022
@bendrucker bendrucker deleted the gh-path-eval branch March 29, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant