Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass only type to EvalExpr when passed detailed types #107

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Mar 20, 2021

See also terraform-linters/tflint-ruleset-aws#48
See also #83

In #83, EvalExpr can now accept a type. If the type is passed, the object that reflects the evaluated result does not need to be sent to the server.

For instance, cty-based evaluation requires passing a complex object, which can cause gob encoding errors. This PR prevents the object from being included in the request when a detailed type is passed.

@wata727 wata727 merged commit ae6749e into master Mar 20, 2021
@wata727 wata727 deleted the do_not_pass_ret_for_server branch March 20, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant