Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Files() method #122

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

jonathansp
Copy link
Contributor

@jonathansp jonathansp commented Jun 11, 2021

Enables the use of Files() method on tflint-plugin-sdk.

This PR also brings a small refactoring as the Files property would conflict with the new Files() method.

@wata727
Copy link
Member

wata727 commented Jun 12, 2021

Looks good. Please note that you need to extend the Runner interface to use it from the plugin. See also #85

@jonathansp jonathansp marked this pull request as ready for review June 14, 2021 10:23
@jonathansp
Copy link
Contributor Author

cc @universam1 @bendrucker

@wata727 wata727 merged commit 8364139 into terraform-linters:master Jun 14, 2021
@wata727
Copy link
Member

wata727 commented Jun 14, 2021

👍

@jonathansp
Copy link
Contributor Author

@wata727 thank you very much! do you think we can tag it in order to update my tflint PR?

@wata727
Copy link
Member

wata727 commented Jun 14, 2021

Please update to the master branch once. The sdk will be released after the server implementation on the TFLint side is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants