Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for TFLint v0.40/v0.41 #263

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Drop support for TFLint v0.40/v0.41 #263

merged 1 commit into from
Jun 18, 2023

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Jun 15, 2023

See also terraform-linters/tflint#1749
See also https://github.com/terraform-linters/tflint/blob/v0.46.1/docs/developer-guide/api_compatibility.md

This PR drops support for TFLint v0.40/v0.41. Plugins built with SDK v0.17 require TFLint v0.42+.

TFLint v0.41 is a version released over 8 months ago. It is in accordance with the future deprecation plan that versions that have passed more than 6 months since the release of the next version (v0.42) will be out of the scope of support. See terraform-linters/tflint#1693 for details.

@@ -180,8 +180,7 @@ message EvaluateExpr {
}

message Request {
bytes expr = 1 [deprecated = true];
Range expr_range = 2 [deprecated = true];
reserved 1, 2;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields are deprecated in #205. SDK v0.14+ and TFLint v0.42+ do not use them.
Support for older SDK versions has already been dropped in terraform-linters/tflint#1749.

On the other hand, note that IncludeNotCreated, which was deprecated in #208, cannot be dropped yet.
This is exposed directly to plugin developers and must be unpublished first.

@wata727 wata727 merged commit 22718fe into master Jun 18, 2023
5 checks passed
@wata727 wata727 deleted the drop_tflint_0.41 branch June 18, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant