Allow use of ${terraform.workspace} in tests #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on a plugin which checks that resource names include
`${terraform.workspace}` (if it's set) -
https://github.com/richardTowers/tflint-ruleset-workspaces/
Currently it's not possible to test this functionality, because (unlike
tflint) tflint-plugin-sdk doesn't support the `${terraform.workspace}`
expression.
Fixing terraform-linters#64
would be nicer, but as this is quite self contained I think it's okay to
add this feature to the TestRunner.
richardTowers
added a commit
to richardTowers/tflint-ruleset-workspaces
that referenced
this pull request
Jan 23, 2021
(They're broken at the moment, pending terraform-linters/tflint-plugin-sdk#99)
wata727
reviewed
Jan 24, 2021
| @@ -187,9 +188,16 @@ func (r *Runner) EvaluateExpr(expr hcl.Expression, ret interface{}, wantTy *cty. | |||
| for _, variable := range r.tfconfig.Module.Variables { | |||
| variables[variable.Name] = variable.Default | |||
| } | |||
| workspace, success := os.LookupEnv("TERRAFORM_WORKSPACE") | |||
There was a problem hiding this comment.
According to the official behavior, TF_WORKSPACE may be better.
https://www.terraform.io/docs/cli/config/environment-variables.html#tf_workspace
richardTowers
added a commit
to richardTowers/tflint-plugin-sdk
that referenced
this pull request
Feb 6, 2021
This is just used in the test runner, but we may as well be consistent with the variable used in terraform and mainline tflint. As suggested here: terraform-linters#99 (comment) As per the docs here: https://www.terraform.io/docs/cli/config/environment-variables.html#tf_workspace
wata727
pushed a commit
that referenced
this pull request
Feb 7, 2021
This is just used in the test runner, but we may as well be consistent with the variable used in terraform and mainline tflint. As suggested here: #99 (comment) As per the docs here: https://www.terraform.io/docs/cli/config/environment-variables.html#tf_workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a plugin which checks that resource names include
${terraform.workspace}(if it's set) -https://github.com/richardTowers/tflint-ruleset-workspaces/
Currently it's not possible to test this functionality, because (unlike
tflint) tflint-plugin-sdk doesn't support the
${terraform.workspace}expression.
Fixing #64
would be nicer, but as this is quite self contained I think it's okay to
add this feature to the TestRunner.