s3_bucket_name: add all documented naming rules
#571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
requested changes
Nov 6, 2023
davimmt
force-pushed
the
aws_s3_bucket_name
branch
from
e803a9a
to
0ad1b56
Compare
|
If everything's OK, I'll only need to write a test for each item in |
|
Unit testing this rule should be fine, no integration tests needed. |
davimmt
commented
Nov 8, 2023
| @@ -81,7 +81,7 @@ func (r *AwsS3BucketNameRule) Check(runner tflint.Runner) error { | |||
| }{ | |||
| { | |||
| Regexp: *regexp.MustCompile(fmt.Sprintf( | |||
| "^(.{0,%d})?(.{%d,})?$", | |||
| "^.{0,%d}$|.{%d,}$", | |||
There was a problem hiding this comment.
Found out about the alternation operator in Go and thought it was easier to read and more go-friendly.
davimmt
commented
Nov 8, 2023
Comment on lines
+99
to
+100
| Regexp: *regexp.MustCompile("^[^a-z0-9]|[^a-z0-9]$"), | ||
| Description: "Bucket names must begin and end with a lowercase letter or number.", |
There was a problem hiding this comment.
The alternation operator could also be used here to merge these two rules in one, just as the docs.
|
Thanks! Will do another review and edit as needed later this week. |
bendrucker
approved these changes
Nov 11, 2023
bendrucker
changed the title
s3_bucket_name: add validationss3_bucket_name: add all documented naming rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this discussion.
Also an alternative to remove hardcoded values from this past issue.