Update disks API version to 2022-03-02 (#214)

terraform-linters · Oct 26, 2022 · c1e0b7b · c1e0b7b
1 parent 47a5e25
commit c1e0b7b
Show file tree

Hide file tree

Showing 12 changed files with 25 additions and 321 deletions.
diff --git a/docs/README.md b/docs/README.md
@@ -14,7 +14,7 @@ This documentation describes a list of rules available by enabling this ruleset.
 
 ## API Specification Rules
 
-These are the rules that warn against invalid values generated from [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs). Currently, 228 rules are available.
+These are the rules that warn against invalid values generated from [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs). Currently, 226 rules are available.
 
 |Rule|Enabled by default|
 | --- | --- |
@@ -164,7 +164,6 @@ These are the rules that warn against invalid values generated from [azure-rest-
 |[azurerm_logic_app_trigger_recurrence_invalid_frequency](rules/azurerm_logic_app_trigger_recurrence_invalid_frequency.md)|✔|
 |[azurerm_maintenance_configuration_invalid_scope](rules/azurerm_maintenance_configuration_invalid_scope.md)|✔|
 |[azurerm_managed_application_definition_invalid_lock_level](rules/azurerm_managed_application_definition_invalid_lock_level.md)|✔|
-|[azurerm_managed_disk_invalid_create_option](rules/azurerm_managed_disk_invalid_create_option.md)|✔|
 |[azurerm_managed_disk_invalid_os_type](rules/azurerm_managed_disk_invalid_os_type.md)|✔|
 |[azurerm_managed_disk_invalid_storage_account_type](rules/azurerm_managed_disk_invalid_storage_account_type.md)|✔|
 |[azurerm_maps_account_invalid_sku_name](rules/azurerm_maps_account_invalid_sku_name.md)|✔|
@@ -217,7 +216,6 @@ These are the rules that warn against invalid values generated from [azure-rest-
 |[azurerm_servicebus_subscription_rule_invalid_filter_type](rules/azurerm_servicebus_subscription_rule_invalid_filter_type.md)|✔|
 |[azurerm_servicebus_topic_invalid_status](rules/azurerm_servicebus_topic_invalid_status.md)|✔|
 |[azurerm_shared_image_invalid_os_type](rules/azurerm_shared_image_invalid_os_type.md)|✔|
-|[azurerm_snapshot_invalid_create_option](rules/azurerm_snapshot_invalid_create_option.md)|✔|
 |[azurerm_sql_database_invalid_create_mode](rules/azurerm_sql_database_invalid_create_mode.md)|✔|
 |[azurerm_storage_account_invalid_access_tier](rules/azurerm_storage_account_invalid_access_tier.md)|✔|
 |[azurerm_storage_account_invalid_account_kind](rules/azurerm_storage_account_invalid_account_kind.md)|✔|

diff --git a/docs/rules/azurerm_managed_disk_invalid_create_option.md b/docs/rules/azurerm_managed_disk_invalid_create_option.md
diff --git a/docs/rules/azurerm_managed_disk_invalid_os_type.md b/docs/rules/azurerm_managed_disk_invalid_os_type.md
@@ -41,4 +41,4 @@ Replace the warned value with a valid value.
 
 This rule is automatically generated from [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs). If you are uncertain about the warning, check the following API schema referenced by this rule.
 
-https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2019-11-01/disk.json
+https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-03-02/disk.json
diff --git a/docs/rules/azurerm_managed_disk_invalid_storage_account_type.md b/docs/rules/azurerm_managed_disk_invalid_storage_account_type.md
@@ -9,6 +9,9 @@ Allowed values are:
 - Premium_LRS
 - StandardSSD_LRS
 - UltraSSD_LRS
+- Premium_ZRS
+- StandardSSD_ZRS
+- PremiumV2_LRS
 
 ## Example
 
@@ -43,4 +46,4 @@ Replace the warned value with a valid value.
 
 This rule is automatically generated from [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs). If you are uncertain about the warning, check the following API schema referenced by this rule.
 
-https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2019-11-01/disk.json
+https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-03-02/disk.json
diff --git a/docs/rules/azurerm_snapshot_invalid_create_option.md b/docs/rules/azurerm_snapshot_invalid_create_option.md
diff --git a/rules/apispec/azurerm_managed_disk_invalid_create_option.go b/rules/apispec/azurerm_managed_disk_invalid_create_option.go
diff --git a/rules/apispec/azurerm_managed_disk_invalid_storage_account_type.go b/rules/apispec/azurerm_managed_disk_invalid_storage_account_type.go
@@ -29,6 +29,9 @@ func NewAzurermManagedDiskInvalidStorageAccountTypeRule() *AzurermManagedDiskInv
 			"Premium_LRS",
 			"StandardSSD_LRS",
 			"UltraSSD_LRS",
+			"Premium_ZRS",
+			"StandardSSD_ZRS",
+			"PremiumV2_LRS",
 		},
 	}
 }

diff --git a/rules/apispec/azurerm_snapshot_invalid_create_option.go b/rules/apispec/azurerm_snapshot_invalid_create_option.go
diff --git a/rules/apispec/provider.go b/rules/apispec/provider.go
@@ -156,7 +156,6 @@ var Rules = []tflint.Rule{
 	NewAzurermLogicAppTriggerRecurrenceInvalidFrequencyRule(),
 	NewAzurermMaintenanceConfigurationInvalidScopeRule(),
 	NewAzurermManagedApplicationDefinitionInvalidLockLevelRule(),
-	NewAzurermManagedDiskInvalidCreateOptionRule(),
 	NewAzurermManagedDiskInvalidOSTypeRule(),
 	NewAzurermManagedDiskInvalidStorageAccountTypeRule(),
 	NewAzurermMapsAccountInvalidSkuNameRule(),
@@ -210,7 +209,6 @@ var Rules = []tflint.Rule{
 	NewAzurermServicebusSubscriptionRuleInvalidFilterTypeRule(),
 	NewAzurermServicebusTopicInvalidStatusRule(),
 	NewAzurermSharedImageInvalidOSTypeRule(),
-	NewAzurermSnapshotInvalidCreateOptionRule(),
 	NewAzurermStorageAccountInvalidAccessTierRule(),
 	NewAzurermStorageAccountInvalidAccountKindRule(),
 	NewAzurermStorageAccountInvalidResourceGroupNameRule(),

diff --git a/tools/apispec-rule-gen/mappings/azurerm_disk_encryption_set.hcl b/tools/apispec-rule-gen/mappings/azurerm_disk_encryption_set.hcl
@@ -1,6 +1,6 @@
 mapping "azurerm_disk_encryption_set" {
-  import_path = "azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2019-11-01/disk.json"
+  import_path = "azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-03-02/disk.json"
 
-  name                = DiskEncryptionSetNameParameter
-  resource_group_name = ResourceGroupNameParameter
+  name                = any // DiskEncryptionSetNameParameter
+  resource_group_name = any // ResourceGroupNameParameter
 }