Add new instance types #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wata727 please take a look |
wata727
reviewed
Jun 3, 2023
| @@ -38,12 +38,16 @@ var validMachineSizes = []string{ | |||
| "Standard_D1", | |||
| "Standard_D11", | |||
| "Standard_D11_v2", | |||
| "Standard_D11_v2_Promo", | |||
There was a problem hiding this comment.
The Promo series certainly seems to exist, but it doesn't seem to be mentioned anywhere in the official documentation. Where are these sources?
https://learn.microsoft.com/en-us/azure/virtual-machines/sizes
wata727
reviewed
Jun 3, 2023
rules/utils.go
Outdated
| "Standard_H16mr", | ||
| "Standard_H16r", | ||
| "Standard_H8", | ||
| "Standard_H8m", |
There was a problem hiding this comment.
- they are not returned by the API.
- They are retired, see https://learn.microsoft.com/en-us/azure/cloud-services/cloud-services-sizes-specs#h-series
On August 31, 2022, we're retiring the following H-series Azure VM sizes:
H8
H8m
H16
H16r
H16m
H16mr
H8 Promo
H8m Promo
H16 Promo
H16r Promo
H16m Promo
H16mr Promo
Would you suggest to keep them? I can update the PR.
There was a problem hiding this comment.
Thank you for your explanation.
I was concerned if anyone was still using these sizes, but according to the article, it seems that no such user exists anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error:
(sorted list in the first commit alphabetically, 2nd commit adds missing VM sizes)