Add terraform_deprecated_lookup rule to the recommended preset

terraform-linters · Sep 30, 2023 · e6651cc · e6651cc
1 parent 6afcb25
commit e6651cc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/docs/rules/README.md b/docs/rules/README.md
@@ -9,7 +9,7 @@ All rules are enabled by default, but by setting `preset = "recommended"`, you c
 |[terraform_comment_syntax](terraform_comment_syntax.md)|Disallow `//` comments in favor of `#`||
 |[terraform_deprecated_index](terraform_deprecated_index.md)|Disallow legacy dot index syntax|✔|
 |[terraform_deprecated_interpolation](terraform_deprecated_interpolation.md)|Disallow deprecated (0.11-style) interpolation|✔|
-|[terraform_deprecated_lookup](terraform_deprecated_lookup.md)|Disallow deprecated `lookup()` function with only 2 arguments.||
+|[terraform_deprecated_lookup](terraform_deprecated_lookup.md)|Disallow deprecated `lookup()` function with only 2 arguments.|✔|
 |[terraform_documented_outputs](terraform_documented_outputs.md)|Disallow `output` declarations without description||
 |[terraform_documented_variables](terraform_documented_variables.md)|Disallow `variable` declarations without description||
 |[terraform_empty_list_equality](terraform_empty_list_equality.md)|Disallow comparisons with `[]` when checking if a collection is empty|✔|

diff --git a/docs/rules/terraform_deprecated_lookup.md b/docs/rules/terraform_deprecated_lookup.md
@@ -2,6 +2,8 @@
 
 Disallow deprecated [`lookup` function](https://developer.hashicorp.com/terraform/language/functions/lookup) usage without a default.
 
+> This rule is enabled by "recommended" preset.
+
 ## Example
 
 ```hcl
@@ -25,7 +27,7 @@ Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0
 
 ## Why
 
-Calling [`lookup`](https://developer.hashicorp.com/terraform/language/functions/lookup) with 2 arguments has been deprecated since Terraform v0.7. `lookup(map, key)` is equivalent to the native index syntax `map[key]`. `lookup` should only be used with the third `default` argument, even though it is optional for backward compatiblity. 
+Calling [`lookup`](https://developer.hashicorp.com/terraform/language/functions/lookup) with 2 arguments has been deprecated since Terraform v0.7. `lookup(map, key)` is equivalent to the native index syntax `map[key]`. `lookup` should only be used with the third `default` argument, even though it is optional for backward compatibility. 
 
 ## How To Fix
 

diff --git a/rules/preset.go b/rules/preset.go
@@ -7,6 +7,7 @@ var PresetRules = map[string][]tflint.Rule{
 		NewTerraformCommentSyntaxRule(),
 		NewTerraformDeprecatedIndexRule(),
 		NewTerraformDeprecatedInterpolationRule(),
+		NewTerraformDeprecatedLookupRule(),
 		NewTerraformDocumentedOutputsRule(),
 		NewTerraformDocumentedVariablesRule(),
 		NewTerraformEmptyListEqualityRule(),
@@ -20,11 +21,11 @@ var PresetRules = map[string][]tflint.Rule{
 		NewTerraformUnusedDeclarationsRule(),
 		NewTerraformUnusedRequiredProvidersRule(),
 		NewTerraformWorkspaceRemoteRule(),
-		NewTerraformDeprecatedLookupRule(),
 	},
 	"recommended": {
 		NewTerraformDeprecatedIndexRule(),
 		NewTerraformDeprecatedInterpolationRule(),
+		NewTerraformDeprecatedLookupRule(),
 		NewTerraformEmptyListEqualityRule(),
 		NewTerraformModulePinnedSourceRule(),
 		NewTerraformModuleVersionRule(),