Merge pull request #124 from wata727/aws_instance_not_specified_iam_p…

…rofile_terraform_version Report `aws_instance_not_specified_iam_profile` only when `terraform_version` is less than 0.8.8
terraform-linters · Jul 9, 2017 · 3082f5c · 3082f5c
2 parents 58bc961 + 8d9bf4e
commit 3082f5c
Show file tree

Hide file tree

Showing 7 changed files with 55 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -57,7 +57,7 @@ Try running TFLint under the directory where Terraform is executed. It detect if
 ```
 $ tflint
 template.tf
-        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)
+        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate the instance.
         ERROR:3 "t1.2xlarge" is invalid instance type.
 
 Result: 2 issues  (1 errors , 0 warnings , 1 notices)

diff --git a/detector/aws_instance_not_specified_iam_profile.go b/detector/aws_instance_not_specified_iam_profile.go
@@ -1,6 +1,7 @@
 package detector
 
 import (
+	"github.com/hashicorp/go-version"
 	"github.com/wata727/tflint/issue"
 	"github.com/wata727/tflint/schema"
 )
@@ -21,11 +22,18 @@ func (d *Detector) CreateAwsInstanceNotSpecifiedIAMProfileDetector() *AwsInstanc
 }
 
 func (d *AwsInstanceNotSpecifiedIAMProfileDetector) Detect(resource *schema.Resource, issues *[]*issue.Issue) {
-	if _, ok := resource.GetToken("iam_instance_profile"); !ok {
+	v1, err := version.NewVersion(d.Config.TerraformVersion)
+	// If `terraform_version` is not set, always detect.
+	if err != nil {
+		v1, _ = version.NewVersion("0.8.0")
+	}
+	v2, _ := version.NewVersion("0.8.8")
+
+	if _, ok := resource.GetToken("iam_instance_profile"); !ok && v1.LessThan(v2) {
 		issue := &issue.Issue{
 			Detector: d.Name,
 			Type:     d.IssueType,
-			Message:  "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)",
+			Message:  "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate the instance.",
 			Line:     resource.Pos.Line,
 			File:     resource.Pos.Filename,
 			Link:     d.Link,

diff --git a/detector/aws_instance_not_specified_iam_profile_test.go b/detector/aws_instance_not_specified_iam_profile_test.go
@@ -13,6 +13,7 @@ func TestDetectAwsInstanceNotSpecifiedIAMProfile(t *testing.T) {
 	cases := []struct {
 		Name   string
 		Src    string
+		Config *config.Config
 		Issues []*issue.Issue
 	}{
 		{
@@ -21,11 +22,12 @@ func TestDetectAwsInstanceNotSpecifiedIAMProfile(t *testing.T) {
 resource "aws_instance" "web" {
     instance_type = "t2.2xlarge"
 }`,
+			Config: config.Init(),
 			Issues: []*issue.Issue{
 				{
 					Detector: "aws_instance_not_specified_iam_profile",
 					Type:     "NOTICE",
-					Message:  "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)",
+					Message:  "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate the instance.",
 					Line:     2,
 					File:     "test.tf",
 					Link:     "https://github.com/wata727/tflint/blob/master/docs/aws_instance_not_specified_iam_profile.md",
@@ -39,6 +41,38 @@ resource "aws_instance" "web" {
     instance_type = "t2.micro"
     iam_instance_profile = "test"
 }`,
+			Config: config.Init(),
+			Issues: []*issue.Issue{},
+		},
+		{
+			Name: "iam_instance_profile is not specified and Terraform version is less than 0.8.8",
+			Src: `
+resource "aws_instance" "web" {
+    instance_type = "t2.2xlarge"
+}`,
+			Config: &config.Config{
+				TerraformVersion: "0.8.7",
+			},
+			Issues: []*issue.Issue{
+				{
+					Detector: "aws_instance_not_specified_iam_profile",
+					Type:     "NOTICE",
+					Message:  "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate the instance.",
+					Line:     2,
+					File:     "test.tf",
+					Link:     "https://github.com/wata727/tflint/blob/master/docs/aws_instance_not_specified_iam_profile.md",
+				},
+			},
+		},
+		{
+			Name: "iam_instance_profile is not specified and Terraform version is 0.8.8",
+			Src: `
+resource "aws_instance" "web" {
+    instance_type = "t2.2xlarge"
+}`,
+			Config: &config.Config{
+				TerraformVersion: "0.8.8",
+			},
 			Issues: []*issue.Issue{},
 		},
 	}
@@ -49,7 +83,7 @@ resource "aws_instance" "web" {
 			"CreateAwsInstanceNotSpecifiedIAMProfileDetector",
 			tc.Src,
 			"",
-			config.Init(),
+			tc.Config,
 			config.Init().NewAwsClient(),
 			&issues,
 		)

diff --git a/docs/aws_instance_not_specified_iam_profile.md b/docs/aws_instance_not_specified_iam_profile.md
@@ -18,7 +18,7 @@ The following is the execution result of TFLint:
 ```
 $ tflint
 template.tf
-        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)
+        NOTICE:1 "iam_instance_profile" is not specified. If you want to change it, you need to recreate the instance.
 
 Result: 1 issues  (0 errors , 0 warnings , 1 notices)
 ```
@@ -28,7 +28,7 @@ You can select only one IAM profile at instance setup. However, if you do not se
 
 Even if you think that you do not need an IAM profile, we recommend that you specify a dummy. Then you can change the privilege when you need it, so you can escape the recreate of the instance.
 
-NOTE: There is good news that Terraform 0.8.8 and later can change it later. However, it is better to give proper authority from the beginning. If you change it later, there is a possibility that your application may have unexpected effects.
+NOTE: There is good news that Terraform 0.8.8 and later can change it later. If `terraform_version` is greater than `0.8.8`, This issue is not reported.
 
 ## How To Fix
 Please add `iam_instance_profile` attribute.
diff --git a/glide.lock b/glide.lock
diff --git a/glide.yaml b/glide.yaml
@@ -30,3 +30,4 @@ import:
 - package: github.com/mitchellh/go-homedir
 - package: github.com/jessevdk/go-flags
   version: ^1.2.0
+- package: github.com/hashicorp/go-version
diff --git a/integration/general/result.json b/integration/general/result.json
@@ -26,7 +26,7 @@
   {
     "detector": "aws_instance_not_specified_iam_profile",
     "type": "NOTICE",
-    "message": "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate instance. (Only less than Terraform 0.8.8)",
+    "message": "\"iam_instance_profile\" is not specified. If you want to change it, you need to recreate the instance.",
     "line": 5,
     "file": "github.com/wata727/example-module/aws_instance.tf",
     "link": "https://github.com/wata727/tflint/blob/master/docs/aws_instance_not_specified_iam_profile.md"