docker: remove unused build tools #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
requested changes
Feb 15, 2021
Dockerfile
Outdated
| @@ -12,7 +12,14 @@ LABEL maintainer=terraform-linters | |||
|
|
|||
| RUN apk add --no-cache ca-certificates | |||
|
|
|||
| COPY --from=builder /tflint/dist/tflint /usr/local/bin | |||
| # copy tflint from builder | |||
There was a problem hiding this comment.
Remove these comments, they are unnecessarily re-stating things that can be readily inferred from the code. Everything happening here is basic and well-documented upstream. You can assume basic understanding of Dockerfiles here and not try to explain how they work.
Dockerfile
Outdated
| WORKDIR /data | ||
|
|
||
| # set the default entrypoint -- when this container is run, use this command | ||
| ENTRYPOINT [ "tflint" ] |
There was a problem hiding this comment.
Keep the formatting consistent with Docker's docs, meaning no array padding:
Dockerfile
Outdated
| ENTRYPOINT [ "tflint" ] | ||
|
|
||
| # as we specified an entrypoint, this is appended as an argument (i.e., `tflint --help`) | ||
| CMD [ "--help" ] |
There was a problem hiding this comment.
Is this really the best default command, as opposed to invoking TFLint with no arguments, which is implicitly the same as tflint .?
There was a problem hiding this comment.
reverting back to original behaviour
pujan14
force-pushed
the
Cleanup-dockerfile
branch
from
9632e82
to
df50044
Compare
Signed-off-by: Pujan Shah <pujan14@gmail.com>
pujan14
force-pushed
the
Cleanup-dockerfile
branch
from
df50044
to
7eac73c
Compare
bendrucker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pujan Shah pujan14@gmail.com
Removed unused build tools from dockerfile and added default argument to image with CMD