Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor terraform_module_pinned_source rule #1124

Merged
merged 6 commits into from
May 28, 2021
Merged

Refactor terraform_module_pinned_source rule #1124

merged 6 commits into from
May 28, 2021

Conversation

bendrucker
Copy link
Member

@bendrucker bendrucker commented May 25, 2021 •
edited
Loading

This PR refactors the terraform_module_pinned_source to remove:

  • A lot of duplicated logic
  • Complex regular expressions (replaced by URL/semver parsers)
  • Mercurial support for Bitbucket, which they don't offer anymore

I'll bring in #1123 once I land this

@bendrucker bendrucker marked this pull request as ready for review May 28, 2021 19:25
@bendrucker bendrucker merged commit ca0cec4 into master May 28, 2021
@bendrucker bendrucker deleted the pinned-module-refactor branch May 28, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bendrucker