terraform: Remove unused internal packages impl #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
remove_unused_funcs
branch
from
12d6466
to
fbe99fb
Compare
wata727
force-pushed
the
remove_unused_funcs
branch
from
fbe99fb
to
3378fb8
Compare
wata727
commented
Jul 11, 2021
| GetForEachAttr(addrs.ForEachAttr, tfdiags.SourceRange) (cty.Value, tfdiags.Diagnostics) | ||
| GetResource(addrs.Resource, tfdiags.SourceRange) (cty.Value, tfdiags.Diagnostics) | ||
| GetLocalValue(addrs.LocalValue, tfdiags.SourceRange) (cty.Value, tfdiags.Diagnostics) | ||
| GetModule(addrs.ModuleCall, tfdiags.SourceRange) (cty.Value, tfdiags.Diagnostics) |
There was a problem hiding this comment.
Currently, evaluation is only supported for input variables, path, and terraform attributes, so remove the others.
wata727
commented
Jul 11, 2021
| // object and instance key data. References to the object must use self, and the | ||
| // key data will only contain count.index or each.key. The static values for | ||
| // terraform and path will also be available in this context. | ||
| func (s *Scope) EvalSelfBlock(body hcl.Body, self cty.Value, schema *configschema.Block, keyData instances.RepetitionData) (cty.Value, tfdiags.Diagnostics) { |
There was a problem hiding this comment.
Similarly, evaluation of self.* is not supported by TFLint.
wata727
commented
Jul 11, 2021
| // First we'll do static validation of the references. This catches things | ||
| // early that might otherwise not get caught due to unknown values being | ||
| // present in the scope during planning. | ||
| if staticDiags := s.Data.StaticValidateReferences(refs, selfAddr); staticDiags.HasErrors() { |
There was a problem hiding this comment.
StaticValidateReferences mainly detect reference errors of resources, data attributes, module attributes early. However, TFLint does not support the evaluation of these attributes.
wata727
commented
Jul 11, 2021
| @@ -72,7 +48,7 @@ func (e *Evaluator) Scope(data lang.Data, self addrs.Referenceable) *lang.Scope | |||
| return &lang.Scope{ | |||
| Data: data, | |||
| SelfAddr: self, | |||
| PureOnly: e.Operation != walkApply && e.Operation != walkDestroy && e.Operation != walkEval, | |||
| PureOnly: true, | |||
There was a problem hiding this comment.
The initial value is always used for the e.Operation. This affects the behavior of some functions, and it is arguable whether this PureOnly: true is appropriate for TFLint evaluation, but it follows current behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1141
In #1141, I just copied the internal packages needed to build TFLint from Terraform v1.0. However, this includes obviously unused implementations. This PR reduces the implementations that need to be maintained by reviewing some features such as evaluation.
This change is made without changing the TFLint interface. Changing the interface may reduce more implementations, but it will be done in other PRs.