fix: return error if plugin is not a file #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
reviewed
Jul 22, 2021
plugin/discovery.go
Outdated
| if os.IsNotExist(err) && runtime.GOOS != "windows" { | ||
| return "", os.ErrNotExist | ||
| } else if !os.IsNotExist(err) { | ||
| } else if !os.IsNotExist(err) && !info.IsDir() { |
There was a problem hiding this comment.
If you add a condition here, it will cause unintended behavior in the following cases:
runtime.GOOS == "linux"- path exists, but it's a directory
In this case, findPluginPath searches for the .exe file, which should only be handled on Windows.
In order to organize the implementation, it may be better to first branch the process according to the runtime OS.
There was a problem hiding this comment.
Hi @wata727, I've refactored it into a separate function to tidy up the intent and understanding.
josh-barker-coles
force-pushed
the
fix/plugin-directory-error
branch
from
de9a071
to
d874840
Compare
|
Thank you! |
|
No worries @wata727 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1168