feat: get architecture for install #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add bash function to get architecture
* match arch to available download assets
I noted that `uname -m` will return aarch64 or aarch,
for arm based machines these changes will allow `os` var to match
multiple architectures and existing download assets.
Tested on darwin x86_64 (amd64), and linux amd64 and arm64.
bendrucker
changed the title
|
Would be nice to have test coverage, attempted that and left notes in #1322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted that
uname -mwill return aarch64 or aarch,for arm based machines these changes will allow
osvar to matchmultiple architectures and existing download assets.
Tested on darwin x86_64 (amd64), and linux amd64 and arm64.