Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sarif: fix incorrect endLine #1746

Merged
merged 2 commits into from Apr 21, 2023
Merged

sarif: fix incorrect endLine #1746

merged 2 commits into from Apr 21, 2023

Conversation

tbutler-qontigo
Copy link
Contributor

Looks like https://github.com/terraform-linters/tflint/pull/1686/files accidentlly changed the End.Line to Start.Column

@tbutler-qontigo tbutler-qontigo changed the title fixes #1745 Fixes SARIF reports reporting the endLine as 1 in all cases (#1745) Apr 20, 2023
Copy link
Member

@bendrucker bendrucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs test coverage

@tbutler-qontigo
Copy link
Contributor Author

This needs test coverage

Apologies, added. Not a GO programmer by trade, but your existing test suite made it easy to add more tests - added for both single and mult-line issues.

Copy link
Member

@bendrucker bendrucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bendrucker bendrucker changed the title Fixes SARIF reports reporting the endLine as 1 in all cases (#1745) serif: fix incorrect endLine Apr 21, 2023
@bendrucker bendrucker merged commit 9c34a74 into terraform-linters:master Apr 21, 2023
11 checks passed
@bendrucker bendrucker changed the title serif: fix incorrect endLine sarif: fix incorrect endLine Apr 21, 2023
@tbutler-qontigo
Copy link
Contributor Author

My pleasure - now when do we get a v0.46.1 release? ;)

@wata727
Copy link
Member

wata727 commented Apr 22, 2023

Released
https://github.com/terraform-linters/tflint/releases/tag/v0.46.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants