Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect pinned sources using regular expressions #194

Conversation

kerscher
Copy link
Contributor

Resolves #193

  • Substitutes strings.Contains for regexp.MatchString
  • Uses regexp.MustCompile as regexp is checked during tests
  • Adds tests for generic git repositories with HTTPS and SSH formats

- Substitutes `strings.Contains` for `regexp.MatchString`
- Uses `regexp.MustCompile` as regexp is checked during tests
- Adds tests for generic git repositories with HTTPS and SSH formats
@kerscher
Copy link
Contributor Author

(I love this tool by the way. I can’t see myself developing without it.)

@wata727 wata727 merged commit 15649d2 into terraform-linters:master May 18, 2018
@wata727
Copy link
Member

wata727 commented May 18, 2018

Great! Thanks for your contributions 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants