Make aws_instance_invalid_ami rule faster #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
aws_instance_invalid_ami
rule fetches all images first. However, these are very large and take a lot of time to complete the request. We just had to provide the--fast
option just to disable this rule.In this pull request, instead of fetching all images first, it will request each time as needed, and cache the list of fetched AMIs. This can reduce the time spent on requests and significantly reduce memory usage.
The number of requests simply increases, but in many cases, it is faster than fetching all images. Here is an example of
time
output:Before
After
NOTE: The
--fast
option will be no longer used, and will be removed in v0.9.