Make non-zero exit status default if issues found #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
added a commit
to marsam/flycheck
that referenced
this pull request
Jul 1, 2019
The --error-with-issues option was removed in v0.9.0. The behavior is now default. See: terraform-linters/tflint#313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
Many popular linters return a non-zero value as exit status when issues found. On the other hand, TFLint normally always returns zero unless the inspection was not successfully completed.
In my opinion, I believe that the exit status should represent whether the inspection itself is an error or not, but I have understood that it is desirable to return non-zero values by default in some practical situations, such as when running on CI.
Based on the above, this PR changes the default behavior to return non-zero exit status if issues found. It is the same as passing the
--error-with-issuesoption. As a result, the option will be removed in v0.9.0.Also, in order to keep the prior behavior, we introduce a new
--forceoption. If the option istrue, TFLint will return zero as before even if issues found.