Added 3 checks for AWS Launch Configuration #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue terraform-linters#253 - adds rules checking in Launch Configuration: - used ami - instance type - instance profile
wata727
approved these changes
Jun 6, 2019
| // NewAwsLaunchConfigurationInvalidIAMProfileRule returns new rule with default attributes | ||
| func NewAwsLaunchConfigurationInvalidIAMProfileRule() *AwsLaunchConfigurationInvalidIAMProfileRule { | ||
| return &AwsLaunchConfigurationInvalidIAMProfileRule{ | ||
| resourceType: "aws_launch_configuration", |
There was a problem hiding this comment.
[nitpicks] It seems that the indentation is broken. It might be better to run gofmt when saving Go files 🙃
|
It is even better if the following documentation updates are included. |
|
Thanks for your feedback and comments, fixed indentation and update documentation with my new rules. |
|
Great work @krzyzakp! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Adds rules checking in Launch Configuration:
Tested on current release, hope that's fair enough to be merged for next release.