Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get an AWS session in the same way as Terraform #361

Merged
merged 1 commit into from Aug 17, 2019

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Jul 15, 2019

Fixes #134

This pull request introduces github.com/hashicorp/aws-sdk-go-base and gets an AWS session in the same way as Terraform.

Also, it will take provider blocks in configuration files into account. For example, the following region settings are also propagated to TFLint, and redundant region settings are not required:

provider "aws" {
  region = "us-east-1"
}

However, this results in changing the priority of the credentials. This is an incompatible change. For example, regions and static credentials in the configuration file have higher priority than environment variables, so you need to set static credentials as a TFLint configuration. See the changed documentation for the new priorities.

In addition, ECS (CodeBuild) task roles and EC2 roles were supported. Please note that Assume role is not supported.

@wata727 wata727 added this to the v0.10.0 milestone Jul 15, 2019
@wata727 wata727 force-pushed the terraform_standard_aws_auth branch from 0ce1f67 to 2f18f98 Compare July 20, 2019 12:31
@wata727 wata727 merged commit 84dfbd9 into master Aug 17, 2019
@wata727 wata727 deleted the terraform_standard_aws_auth branch August 17, 2019 07:53
@wata727 wata727 mentioned this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tflint --deep issues
1 participant