New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix values for excess_capacity_termination_policy #400

Merged

wata727 merged 1 commit into terraform-linters:master from alzabo:fix_spot_excess_capacity_termination_policy

Aug 24, 2019

Contributor

alzabo commented Aug 23, 2019

The values the Terraform provider accepts are "Default" and
"NoTermination".


          Fix values for excess_capacity_termination_policy

299582f

The values the Terraform provider accepts are ["Default" and
"NoTermination"][spot_fleet_request_code].

[spot_fleet_request_code]: https://github.com/terraform-providers/terraform-provider-aws/blob/3f4ae7f126a63642e443d5e9ff09e8cec47823f9/aws/resource_aws_spot_fleet_request.go#L319-L320

Member

wata727 commented Aug 24, 2019 •

edited

Loading

Provided constants do not have the correct casing so going with hard-coded values.

😭

https://github.com/terraform-providers/terraform-provider-aws/blob/3f4ae7f126a63642e443d5e9ff09e8cec47823f9/aws/resource_aws_spot_fleet_request.go#L312

wata727 merged commit c870f9b into terraform-linters:master

Member

wata727 commented Aug 24, 2019

@alzabo Thank you!

wata727 mentioned this pull request

Manually maintain updated SDK-based validation rules #401

Merged

wata727 mentioned this pull request

Generate rules from Terraform provider terraform-linters/tflint-ruleset-aws#29

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment